Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2183033003: chrome/app: Change auto to not deduce raw pointers. (Closed)

Created:
4 years, 4 months ago by vmpstr
Modified:
4 years, 4 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, danakj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chrome/app: Change auto to not deduce raw pointers. This patch updates the code to prevent auto deducing to a raw pointer. R=grt@chromium.org BUG=554600 Committed: https://crrev.com/3af234130c64de89299201845b46dcbd11eae4b1 Cr-Commit-Position: refs/heads/master@{#408190}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/app/chrome_main_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
vmpstr
Please take a look.
4 years, 4 months ago (2016-07-27 00:32:56 UTC) #1
grt (UTC plus 2)
lgtm
4 years, 4 months ago (2016-07-27 07:43:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2183033003/1
4 years, 4 months ago (2016-07-27 17:45:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 18:28:20 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 18:30:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3af234130c64de89299201845b46dcbd11eae4b1
Cr-Commit-Position: refs/heads/master@{#408190}

Powered by Google App Engine
This is Rietveld 408576698