net/base/mime_util.cc - Issue 218303002: Fix: canPlayType() gives false positive for */ogg and audio/x-wav

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/mime_util.cc

Issue 218303002: Fix: canPlayType() gives false positive for */ogg and audio/x-wav (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/base/mime_util.cc

diff --git a/net/base/mime_util.cc b/net/base/mime_util.cc

index 2dee17dab1d2d41a89a94093acd84b3d7a913f27..1d03482ec16917ddbc1c401cc2db630ace3a5ddf 100644

--- a/net/base/mime_util.cc

+++ b/net/base/mime_util.cc

@@ -434,7 +434,11 @@ struct MediaFormatStrict {

static const MediaFormatStrict format_codec_mappings[] = {

{ "video/webm", "opus,vorbis,vp8,vp8.0,vp9,vp9.0" },

{ "audio/webm", "opus,vorbis" },

- { "audio/wav", "1" }

+ { "audio/wav", "1" },

+ { "audio/x-wav", "1" },

+ { "video/ogg", "opus, theora, vorbis" },

scherkus (not reviewing) 2014/04/02 16:26:46 nit: the other lists doesn't appear to not have sp

amogh.bihani 2014/04/03 03:57:13 Done.

+ { "audio/ogg", "opus, vorbis" },

+ { "application/ogg", "opus, theora, vorbis" }

};

MimeUtil::MimeUtil() {

« no previous file with comments | « content/browser/media/media_canplaytype_browsertest.cc ('k') | net/base/mime_util_unittest.cc » ('j') | net/base/mime_util_unittest.cc » ('J')