chrome/browser/task_management/sampling/task_manager_impl.h - Issue 2183023005: TaskManager: unique_ptr<> ownership of TaskGroups

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_management/sampling/task_manager_impl.h

Issue 2183023005: TaskManager: unique_ptr<> ownership of TaskGroups (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tm_default_selection

Patch Set: TaskManager: use containers of unique_ptrs instead of stl_util.h Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/task_management/sampling/task_group.cc ('k') | chrome/browser/task_management/sampling/task_manager_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/task_management/sampling/task_manager_impl.h

diff --git a/chrome/browser/task_management/sampling/task_manager_impl.h b/chrome/browser/task_management/sampling/task_manager_impl.h

index 0e31ff5b01a4daa2e2a0cc955768ae5451cc5206..70de5121bafd30841fc86dc906f275c9924c0f74 100644

--- a/chrome/browser/task_management/sampling/task_manager_impl.h

+++ b/chrome/browser/task_management/sampling/task_manager_impl.h

@@ -125,8 +125,7 @@ class TaskManagerImpl :

const base::Closure on_background_data_ready_callback_;

// Map TaskGroups by the IDs of the processes they represent.

- // Keys and values are unique (no duplicates).

- std::map<base::ProcessId, TaskGroup*> task_groups_by_proc_id_;

+ std::map<base::ProcessId, std::unique_ptr<TaskGroup>> task_groups_by_proc_id_;

// Map each task by its ID to the TaskGroup on which it resides.

// Keys are unique but values will have duplicates (i.e. multiple tasks