Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: chrome/browser/task_management/providers/child_process_task_provider.h

Issue 2183023005: TaskManager: unique_ptr<> ownership of TaskGroups (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tm_default_selection
Patch Set: TaskManager: use containers of unique_ptrs instead of stl_util.h Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/task_management/providers/child_process_task_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/task_management/providers/child_process_task_provider.h
diff --git a/chrome/browser/task_management/providers/child_process_task_provider.h b/chrome/browser/task_management/providers/child_process_task_provider.h
index 0c61b68b92520b35f0ddf52fc0c83031dc2f3f18..398c6302a08654c6d6df04c0d67f0c10e32fe112 100644
--- a/chrome/browser/task_management/providers/child_process_task_provider.h
+++ b/chrome/browser/task_management/providers/child_process_task_provider.h
@@ -65,8 +65,8 @@ class ChildProcessTaskProvider
void DeleteTask(base::ProcessHandle handle);
// A map to track ChildProcessTask's by their handles.
- using HandleToTaskMap = std::map<base::ProcessHandle, ChildProcessTask*>;
- HandleToTaskMap tasks_by_handle_;
+ std::map<base::ProcessHandle, std::unique_ptr<ChildProcessTask>>
+ tasks_by_handle_;
// A map to track ChildProcessTask's by their PIDs.
//
@@ -80,8 +80,7 @@ class ChildProcessTaskProvider
// TODO(afakhry): Fix this either by keeping the handle open via
// |base::Process|, or amending the |BrowserChildProcessObserver| interface to
// supply the PID.
- using PidToTaskMap = std::map<base::ProcessId, ChildProcessTask*>;
- PidToTaskMap tasks_by_pid_;
+ std::map<base::ProcessId, ChildProcessTask*> tasks_by_pid_;
// Always keep this the last member of this class to make sure it's the
// first thing to be destructed.
« no previous file with comments | « no previous file | chrome/browser/task_management/providers/child_process_task_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698