Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 2183023003: Add a Windows layout test for validating symbol CMAP encoding support (Closed)

Created:
4 years, 4 months ago by drott
Modified:
4 years, 4 months ago
Reviewers:
kojii, eae, behdad
CC:
blink-reviews, chromium-reviews
Base URL:
dilbert@roettsch.es:dev/blink/src@symbolCmapRefTest
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a Windows layout test for validating symbol CMAP encoding support In version 1.3.0 HarfBuzz adds support [1] for symbol encoding CMAP tables (platform ID = 3, encoding ID = 0, glyphs offset by 0xF000), for which support in Blink regressed when we moved to the OpenType functions from HarfBuzz. This layout test adds a custom SymbolCMAPTest font which uses the Microsoft specific symbol CMAP encoding. It also adds a reference font which has the same glyph for comparison at Private Use area codepoint 0xE000. The test font's CMAP table for platformID="3" looks as follows, when dumped using ttx: <cmap_format_4 platformID="3" platEncID="0" language="0"> <map code="0xf020" name="space"/> <map code="0xf041" name="A"/> </cmap_format_4> So, it was verified to follow the Symbol CMAP encoding pattern. [1] https://github.com/behdad/harfbuzz/commit/34f9aa582c3a03b578c7eae3d2e8860a0bd5cb00 BUG=627953 R=behdad,kojii,eae Committed: https://crrev.com/b550f7d3b713058b9a719fdfd79cd863638d6327 Cr-Commit-Position: refs/heads/master@{#407794}

Patch Set 1 #

Patch Set 2 : Fix typos, fix base branch reference #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/NeverFixTests View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/resources/SymbolCMAPTest.ttf View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/resources/SymbolCMAPTestRef.ttf View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/symbol-cmap.html View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/symbol-cmap-expected.html View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (16 generated)
drott
4 years, 4 months ago (2016-07-26 13:13:03 UTC) #5
drott
4 years, 4 months ago (2016-07-26 13:25:35 UTC) #7
kojii
lgtm, you're amazing.
4 years, 4 months ago (2016-07-26 13:35:20 UTC) #13
drott
On 2016/07/26 at 13:35:20, kojii wrote: > lgtm, you're amazing. Very kind, Koji, thank you ...
4 years, 4 months ago (2016-07-26 13:39:33 UTC) #15
behdad
lgtm
4 years, 4 months ago (2016-07-26 14:19:12 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2183023003/20001
4 years, 4 months ago (2016-07-26 14:51:15 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-26 14:54:02 UTC) #22
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/b550f7d3b713058b9a719fdfd79cd863638d6327 Cr-Commit-Position: refs/heads/master@{#407794}
4 years, 4 months ago (2016-07-26 14:55:56 UTC) #24
eae
4 years, 4 months ago (2016-07-26 17:09:52 UTC) #25
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698