Associate excludes with context data.

Associate excludes with context data.

A step towards centralizing file exclusion handling (which is currently duplicated by all analyzer clients).

BUG=
R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/065238943adbb21e43d2db5c7e2e25b90b870947

[pquitslund, 2016-07-26 17:14:37]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[scheglov, 2016-07-26 17:21:20]

LGTM

https://codereview.chromium.org/2183003003/diff/1/pkg/analyzer/lib/src/contex...
File pkg/analyzer/lib/src/context/context.dart (right):

https://codereview.chromium.org/2183003003/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/context.dart:48: final
ResultDescriptor<List<String>> CONTEXT_EXCLUDES =
ListResultDescriptor<String>

https://codereview.chromium.org/2183003003/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/context.dart:49: new
ResultDescriptorImpl('context.excludes', const <String>[]);
Currently we use the name of the ResultDescriptor variable as the name of the
result.
I.e. 'CONTEXT_EXCLUDES' instead of 'context.excludes'.

[pquitslund, 2016-07-26 17:24:15]

Thanks!

https://codereview.chromium.org/2183003003/diff/1/pkg/analyzer/lib/src/contex...
File pkg/analyzer/lib/src/context/context.dart (right):

https://codereview.chromium.org/2183003003/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/context.dart:48: final
ResultDescriptor<List<String>> CONTEXT_EXCLUDES =
On 2016/07/26 17:21:20, scheglov wrote:
> ListResultDescriptor<String>

Done.

https://codereview.chromium.org/2183003003/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/context.dart:49: new
ResultDescriptorImpl('context.excludes', const <String>[]);
On 2016/07/26 17:21:20, scheglov wrote:
> Currently we use the name of the ResultDescriptor variable as the name of the
> result.
> I.e. 'CONTEXT_EXCLUDES' instead of 'context.excludes'.

Done.

[pquitslund, 2016-07-26 17:24:44]

Description was changed from

==========
Associate excludes with context data.

A step towards centralizing file exclusion handling (which is currently
duplicated by all analyzer clients).

BUG=
==========

to

==========
Associate excludes with context data.

A step towards centralizing file exclusion handling (which is currently
duplicated by all analyzer clients).

BUG=
R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/065238943adbb21e43d2db5c7e2e25b90b870947
==========

[pquitslund, 2016-07-26 17:24:46]

Committed patchset #1 (id:1) manually as
065238943adbb21e43d2db5c7e2e25b90b870947 (presubmit successful).

[Brian Wilkerson, 2016-07-27 14:52:09]

lgtm