Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2183003002:
Allow configuration of info_plist_{,target} in ios_xctest_test. (Closed)
DescriptionAllow configuration of info_plist_{,target} in ios_xctest_test.
Some XCTests needs a different Info.plist file, so let them
configure it either via the info_plist or info_plist_target
parameters and only use the default value if neither is set.
BUG=629867
Committed: https://crrev.com/c8919c23569d0efd909965720ce68b895120ed46
Cr-Commit-Position: refs/heads/master@{#407778}
Patch Set 1 #
Total comments: 2
Depends on Patchset: Messages
Total messages: 22 (14 generated)
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Allow configuration of info_plist_,target} in ios_xctest_test. BUG=630616 ========== to ========== Allow configuration of info_plist_,target} in ios_xctest_test. BUG=629867 ==========
sdefresne@chromium.org changed reviewers: + stkhapugin@chromium.org
Please take a look and send to CQ if LGTY.
Description was changed from
==========
Allow configuration of info_plist_,target} in ios_xctest_test.
BUG=629867
==========
to
==========
Allow configuration of info_plist_{,target} in ios_xctest_test.
Some XCTests needs a different Info.plist file, so let them
configure it either via the info_plist or info_plist_target
parameters and only use the default value if neither is
set.
BUG=629867
==========
Description was changed from
==========
Allow configuration of info_plist_{,target} in ios_xctest_test.
Some XCTests needs a different Info.plist file, so let them
configure it either via the info_plist or info_plist_target
parameters and only use the default value if neither is
set.
BUG=629867
==========
to
==========
Allow configuration of info_plist_{,target} in ios_xctest_test.
Some XCTests needs a different Info.plist file, so let them
configure it either via the info_plist or info_plist_target
parameters and only use the default value if neither is set.
BUG=629867
==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
sdefresne@chromium.org changed reviewers: + olivierrobin@chromium.org - stkhapugin@chromium.org
olivierrobin@google.com changed reviewers: + olivierrobin@google.com
https://codereview.chromium.org/2183003002/diff/1/build/config/ios/rules.gni File build/config/ios/rules.gni (right): https://codereview.chromium.org/2183003002/diff/1/build/config/ios/rules.gni#... build/config/ios/rules.gni:1180: info_plist = "//build/config/ios/Host-Info.plist" should we not use info_plist_target if it is defined?
https://codereview.chromium.org/2183003002/diff/1/build/config/ios/rules.gni File build/config/ios/rules.gni (right): https://codereview.chromium.org/2183003002/diff/1/build/config/ios/rules.gni#... build/config/ios/rules.gni:1180: info_plist = "//build/config/ios/Host-Info.plist" On 2016/07/26 12:51:34, olivierrobin wrote: > should we not use info_plist_target if it is defined? We already forward the "info_plist" if it is defined with the "forward_variables_from" call earlier. Here we only set a default value if neither info_plist nor info_plist_target where defined by the invoker.
The CQ bit was checked by olivierrobin@google.com
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from
==========
Allow configuration of info_plist_{,target} in ios_xctest_test.
Some XCTests needs a different Info.plist file, so let them
configure it either via the info_plist or info_plist_target
parameters and only use the default value if neither is set.
BUG=629867
==========
to
==========
Allow configuration of info_plist_{,target} in ios_xctest_test.
Some XCTests needs a different Info.plist file, so let them
configure it either via the info_plist or info_plist_target
parameters and only use the default value if neither is set.
BUG=629867
==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from
==========
Allow configuration of info_plist_{,target} in ios_xctest_test.
Some XCTests needs a different Info.plist file, so let them
configure it either via the info_plist or info_plist_target
parameters and only use the default value if neither is set.
BUG=629867
==========
to
==========
Allow configuration of info_plist_{,target} in ios_xctest_test.
Some XCTests needs a different Info.plist file, so let them
configure it either via the info_plist or info_plist_target
parameters and only use the default value if neither is set.
BUG=629867
Committed: https://crrev.com/c8919c23569d0efd909965720ce68b895120ed46
Cr-Commit-Position: refs/heads/master@{#407778}
==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/c8919c23569d0efd909965720ce68b895120ed46 Cr-Commit-Position: refs/heads/master@{#407778}
Message was sent while issue was closed.
stkhapugin@chromium.org changed reviewers: + stkhapugin@chromium.org
Message was sent while issue was closed.
lgtm |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
