iccjpeg: Add README with license information.

iccjpeg: Add README with license information.

Make source files refer to README for license details.
Covered by same copyright and license as libjpeg.

BUG=98137
TESTED=tools/checklicenses/checklicenses.py --ignore-suppressions third_party/iccjpeg/
R=brettw@chromium.org

Committed: https://crrev.com/a1a8185c72545ce458e3898e98c0dae095977f0e
Cr-Commit-Position: refs/heads/master@{#409600}

[fbarchard1, 2016-07-27 00:22:28]

The CQ bit was checked by fbarchard@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 00:23:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fbarchard1, 2016-07-27 00:33:37]

The CQ bit was checked by fbarchard@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 00:33:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fbarchard1, 2016-07-27 00:45:07]

Was failing:
tools/checklicenses/checklicenses.py --ignore-suppressions third_party/iccjpeg/
'third_party/iccjpeg/iccjpeg.c' has non-whitelisted license 'UNKNOWN'
'third_party/iccjpeg/iccjpeg.h' has non-whitelisted license 'UNKNOWN'

Now:
tools/checklicenses/checklicenses.py --ignore-suppressions third_party/iccjpeg/
Checking: /usr/local/google/home/fbarchard/build/chrome/src/third_party/iccjpeg


SUCCESS

[fbarchard1, 2016-07-27 00:45:43]

Description was changed from

==========
Add copyright to source files. The LICENSE file indicates the same copyright as
standard libjpeg, so the style of copyright is taken from libjpeg.

BUG=98137
TESTED=tools/checklicenses/checklicenses.py --ignore-suppressions
third_party/iccjpeg/
R=thakis@chromium.org
==========

to

==========
Add copyright to source files. The LICENSE file indicates the same copyright as
standard libjpeg, so the style of copyright is taken from libjpeg.

BUG=98137
TESTED=tools/checklicenses/checklicenses.py --ignore-suppressions
third_party/iccjpeg/
R=brettw@chromium.org
==========

[fbarchard1, 2016-07-27 00:45:43]

fbarchard@google.com changed reviewers:
+ brettw@chromium.org
- thakis@chromium.org

[fbarchard1, 2016-07-27 00:47:27]

Description was changed from

==========
Add copyright to source files. The LICENSE file indicates the same copyright as
standard libjpeg, so the style of copyright is taken from libjpeg.

BUG=98137
TESTED=tools/checklicenses/checklicenses.py --ignore-suppressions
third_party/iccjpeg/
R=brettw@chromium.org
==========

to

==========
Add README with license information.

Make source files refer to README for license details.
Covered by same copyright and license as libjpeg.

BUG=98137
TESTED=tools/checklicenses/checklicenses.py --ignore-suppressions
third_party/iccjpeg/
R=brettw@chromium.org
==========

[fbarchard1, 2016-07-27 00:48:08]

Description was changed from

==========
Add README with license information.

Make source files refer to README for license details.
Covered by same copyright and license as libjpeg.

BUG=98137
TESTED=tools/checklicenses/checklicenses.py --ignore-suppressions
third_party/iccjpeg/
R=brettw@chromium.org
==========

to

==========
iccjpeg: Add README with license information.

Make source files refer to README for license details.
Covered by same copyright and license as libjpeg.

BUG=98137
TESTED=tools/checklicenses/checklicenses.py --ignore-suppressions
third_party/iccjpeg/
R=brettw@chromium.org
==========

[Nico, 2016-07-29 22:27:43]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-07-29 22:27:43]

https://codereview.chromium.org/2182993003/diff/40001/third_party/iccjpeg/icc...
File third_party/iccjpeg/iccjpeg.h (right):

https://codereview.chromium.org/2182993003/diff/40001/third_party/iccjpeg/icc...
third_party/iccjpeg/iccjpeg.h:6: * For conditions of distribution and use, see
the accompanying README file.
are you upstreaming this change somewhere?

[fbarchard1, 2016-07-29 23:50:11]

On 2016/07/29 22:27:43, Nico (ooo until Aug 1) wrote:
>
https://codereview.chromium.org/2182993003/diff/40001/third_party/iccjpeg/icc...
> File third_party/iccjpeg/iccjpeg.h (right):
> 
>
https://codereview.chromium.org/2182993003/diff/40001/third_party/iccjpeg/icc...
> third_party/iccjpeg/iccjpeg.h:6: * For conditions of distribution and use, see
> the accompanying README file.
> are you upstreaming this change somewhere?

No, not planning to.
In that statement, I used to say
For conditions of distribution and use, see the accompanying LICENSE file.
But tools/checklicenses/checklicenses.py doesn't recognise that name, so I
followed what libjpeg does, and it has both a README and LICENSE file, and
refers to the README.

[Daniel Berlin, 2016-08-02 23:51:31]

dannyb@google.com changed reviewers:
+ dannyb@google.com

[Daniel Berlin, 2016-08-02 23:51:32]

lgtm

[fbarchard1, 2016-08-03 01:00:12]

The CQ bit was checked by fbarchard@google.com

[commit-bot: I haz the power, 2016-08-03 01:00:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 01:00:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 01:00:56]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Nico, 2016-08-03 14:26:07]

If we're just adding these downstream, I think suppressing the license check for
this directory is just as good and doesn't cause us a downstream diff (?)

[brettw, 2016-08-03 17:14:43]

Owners LGTM based on dannyb's review. I'm not necessarily saying this is better
than whitelisting the directory, though.

[fbarchard1, 2016-08-03 17:28:33]

The CQ bit was checked by fbarchard@google.com

[commit-bot: I haz the power, 2016-08-03 17:29:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fbarchard1, 2016-08-03 18:25:56]

On 2016/08/03 14:26:07, Nico wrote:
> If we're just adding these downstream, I think suppressing the license check
for
> this directory is just as good and doesn't cause us a downstream diff (?)

Re upstreaming - always a good idea.  I've made a note in the bug that it would
be good to upstream the license info.

The license was already documented, but the license check script couldnt
find/parse it.  So I dont think suppressing the warning is correct,  It would be
good to fix the script to recognize the file 'LICENSE' is acceptable, as well as
the file 'README'
The license script documentation says you should remove the suppression once the
license is included, so thats a followup item too.  Also jpeg already works, and
should be removed, while jpeg-turbo does not pass and should be fixed.

[commit-bot: I haz the power, 2016-08-03 19:54:54]

Description was changed from

==========
iccjpeg: Add README with license information.

Make source files refer to README for license details.
Covered by same copyright and license as libjpeg.

BUG=98137
TESTED=tools/checklicenses/checklicenses.py --ignore-suppressions
third_party/iccjpeg/
R=brettw@chromium.org
==========

to

==========
iccjpeg: Add README with license information.

Make source files refer to README for license details.
Covered by same copyright and license as libjpeg.

BUG=98137
TESTED=tools/checklicenses/checklicenses.py --ignore-suppressions
third_party/iccjpeg/
R=brettw@chromium.org
==========

[commit-bot: I haz the power, 2016-08-03 19:55:00]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-03 19:57:10]

Description was changed from

==========
iccjpeg: Add README with license information.

Make source files refer to README for license details.
Covered by same copyright and license as libjpeg.

BUG=98137
TESTED=tools/checklicenses/checklicenses.py --ignore-suppressions
third_party/iccjpeg/
R=brettw@chromium.org
==========

to

==========
iccjpeg: Add README with license information.

Make source files refer to README for license details.
Covered by same copyright and license as libjpeg.

BUG=98137
TESTED=tools/checklicenses/checklicenses.py --ignore-suppressions
third_party/iccjpeg/
R=brettw@chromium.org

Committed: https://crrev.com/a1a8185c72545ce458e3898e98c0dae095977f0e
Cr-Commit-Position: refs/heads/master@{#409600}
==========

[commit-bot: I haz the power, 2016-08-03 19:57:12]

Patchset 3 (id:??) landed as
https://crrev.com/a1a8185c72545ce458e3898e98c0dae095977f0e
Cr-Commit-Position: refs/heads/master@{#409600}