Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2182883004: Big Endian support part 4 (Closed)

Created:
4 years, 4 months ago by jungshik at Google
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master
Target Ref:
refs/heads/master
Project:
icu
Visibility:
Public.

Description

Big Endian support part 4 Delete three pre-built assembly source files because they're now generated at build-time. Update data build scripts and README.chromium accordingly. Update copy_data.sh and copy_data_android.sh so that the assembly source files are not copied. Besides, convert the little endian data bundle to the big endian data bundle for non-Android platforms. BUG=v8:4828 TEST=Rebuild icu data following the procedure in README.chromium TEST='gn args <builddir>' with icu_use_data_file set to true or false TEST=build base_unittests and run with --gtest_filter=ICU* TEST=build base_unittests and run with --gtest_filter=Message*ormat* TEST=build 'd8' (v8) and try `(new Date()).toLocaleString("de")` Committed: https://chromium.googlesource.com/chromium/deps/icu/+/3655cfba9225dde0b1e33a888f69af35e89efe55

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -16 lines) Patch
M README.chromium View 2 chunks +6 lines, -9 lines 0 comments Download
M scripts/copy_data.sh View 1 chunk +9 lines, -4 lines 0 comments Download
M scripts/copy_data_android.sh View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jungshik at Google
4 years, 4 months ago (2016-07-27 18:52:16 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3655cfba9225dde0b1e33a888f69af35e89efe55 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698