chrome/browser/permissions/permission_request_manager_unittest.cc - Issue 2182883002: Permissions: Rename PermissionBubbleView to PermissionPromptInterface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_request_manager_unittest.cc

Issue 2182883002: Permissions: Rename PermissionBubbleView to PermissionPromptInterface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Further renames Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/permissions/permission_request_manager_browsertest.cc ('K') | « chrome/browser/permissions/permission_request_manager_browsertest.cc ('k') | chrome/browser/safe_browsing/permission_reporter_browsertest.cc » ('j') | chrome/browser/safe_browsing/permission_reporter_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/permissions/permission_request_manager_unittest.cc

diff --git a/chrome/browser/permissions/permission_request_manager_unittest.cc b/chrome/browser/permissions/permission_request_manager_unittest.cc

index f1e90b4493a470c2105a8521092bd36eb06cb9f5..96ba18a5206ab24b25f981ce39c34bc71d2154ea 100644

--- a/chrome/browser/permissions/permission_request_manager_unittest.cc

+++ b/chrome/browser/permissions/permission_request_manager_unittest.cc

@@ -13,7 +13,7 @@

#include "chrome/browser/permissions/permission_request.h"

#include "chrome/browser/permissions/permission_request_manager.h"

#include "chrome/browser/permissions/permission_uma_util.h"

-#include "chrome/browser/ui/website_settings/mock_permission_bubble_factory.h"

+#include "chrome/browser/ui/website_settings/mock_permission_prompt_factory.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/test/base/chrome_render_view_host_test_harness.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -40,7 +40,7 @@ class PermissionRequestManagerTest : public ChromeRenderViewHostTestHarness {

NavigateAndCommit(GURL("http://www.google.com"));

manager_.reset(new PermissionRequestManager(web_contents()));

- view_factory_.reset(new MockPermissionBubbleFactory(manager_.get()));

+ view_factory_.reset(new MockPermissionPromptFactory(manager_.get()));

}

void TearDown() override {

@@ -91,7 +91,7 @@ class PermissionRequestManagerTest : public ChromeRenderViewHostTestHarness {

MockPermissionRequest iframe_request_same_domain_;

MockPermissionRequest iframe_request_other_domain_;

std::unique_ptr<PermissionRequestManager> manager_;

- std::unique_ptr<MockPermissionBubbleFactory> view_factory_;

+ std::unique_ptr<MockPermissionPromptFactory> view_factory_;

raymes 2016/08/01 00:58:13 prompt_factory

tsergeant 2016/08/01 23:41:12 Done.

};

TEST_F(PermissionRequestManagerTest, SingleRequest) {