Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2182873005: Make the yasm copy target be type 'none' rather than type 'executable' (Closed)

Created:
4 years, 4 months ago by bsalomon
Modified:
4 years, 4 months ago
Reviewers:
msarett, vjiaoblack
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make the yasm copy target be type 'none' rather than type 'executable' GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2182873005 Committed: https://skia.googlesource.com/skia/+/81ce4a9c551f5ecbd549b992b1f1e7689049c615

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M gyp/libjpeg-turbo.gyp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
bsalomon
4 years, 4 months ago (2016-07-27 18:19:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182873005/1
4 years, 4 months ago (2016-07-27 18:19:54 UTC) #5
msarett
lgtm
4 years, 4 months ago (2016-07-27 18:20:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182873005/1
4 years, 4 months ago (2016-07-27 18:56:56 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 19:07:46 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/81ce4a9c551f5ecbd549b992b1f1e7689049c615

Powered by Google App Engine
This is Rietveld 408576698