Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: chrome/installer/setup/archive_patch_helper_unittest.cc

Issue 2182873003: Add bounds check for negative ctrlsrc->z. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/test/data/installer/bin.old » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/files/file_path.h" 5 #include "base/files/file_path.h"
6 #include "base/files/file_util.h" 6 #include "base/files/file_util.h"
7 #include "base/files/scoped_temp_dir.h" 7 #include "base/files/scoped_temp_dir.h"
8 #include "base/path_service.h" 8 #include "base/path_service.h"
9 #include "chrome/common/chrome_paths.h" 9 #include "chrome/common/chrome_paths.h"
10 #include "chrome/installer/setup/archive_patch_helper.h" 10 #include "chrome/installer/setup/archive_patch_helper.h"
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 base::FilePath dest = test_dir_.path().AppendASCII("archive2.7z"); 52 base::FilePath dest = test_dir_.path().AppendASCII("archive2.7z");
53 installer::ArchivePatchHelper archive_helper(test_dir_.path(), 53 installer::ArchivePatchHelper archive_helper(test_dir_.path(),
54 base::FilePath(), 54 base::FilePath(),
55 src, 55 src,
56 dest); 56 dest);
57 archive_helper.set_last_uncompressed_file(patch); 57 archive_helper.set_last_uncompressed_file(patch);
58 EXPECT_TRUE(archive_helper.EnsemblePatch() || archive_helper.BinaryPatch()); 58 EXPECT_TRUE(archive_helper.EnsemblePatch() || archive_helper.BinaryPatch());
59 base::FilePath base = data_dir_.AppendASCII("archive2.7z"); 59 base::FilePath base = data_dir_.AppendASCII("archive2.7z");
60 EXPECT_TRUE(base::ContentsEqual(dest, base)); 60 EXPECT_TRUE(base::ContentsEqual(dest, base));
61 } 61 }
62
63 TEST_F(ArchivePatchHelperTest, InvalidDiff_MisalignedCblen) {
64 base::FilePath src = data_dir_.AppendASCII("bin.old");
65 base::FilePath patch = data_dir_.AppendASCII("misaligned_cblen.diff");
66 base::FilePath dest = test_dir_.path().AppendASCII("bin.new");
67 installer::ArchivePatchHelper archive_helper(test_dir_.path(),
68 base::FilePath(),
69 src,
70 dest);
71 archive_helper.set_last_uncompressed_file(patch);
72 // Should fail, but not crash.
73 EXPECT_FALSE(archive_helper.BinaryPatch());
74 }
75
76 TEST_F(ArchivePatchHelperTest, InvalidDiff_NegativeSeek) {
77 base::FilePath src = data_dir_.AppendASCII("bin.old");
78 base::FilePath patch = data_dir_.AppendASCII("negative_seek.diff");
79 base::FilePath dest = test_dir_.path().AppendASCII("bin.new");
80 installer::ArchivePatchHelper archive_helper(test_dir_.path(),
81 base::FilePath(),
82 src,
83 dest);
84 archive_helper.set_last_uncompressed_file(patch);
85 // Should fail, but not crash.
86 EXPECT_FALSE(archive_helper.BinaryPatch());
87 }
OLDNEW
« no previous file with comments | « no previous file | chrome/test/data/installer/bin.old » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698