Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(884)

Issue 218283002: tests: import unittest via package: url (Closed)

Created:
6 years, 9 months ago by kevmoo
Modified:
6 years, 8 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

tests: import unittest via package: url R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=34602

Patch Set 1 #

Patch Set 2 : tweak #

Patch Set 3 : nits #

Total comments: 1

Patch Set 4 : just async lib for now #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -30 lines) Patch
M tests/lib/async/deferred/deferred_fail_to_load_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/deferred/deferred_in_isolate_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/first_regression_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/future_timeout_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/multiple_timer_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/schedule_microtask2_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/schedule_microtask5_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_controller_async_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_first_where_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_from_iterable_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_last_where_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_periodic2_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_periodic3_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_periodic4_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_periodic5_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_periodic_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_single_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_single_to_multi_subscriber_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_state_helper.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_state_nonzero_timer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_state_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_subscription_as_future_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_transform_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/timer_cancel1_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/timer_cancel2_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/timer_cancel_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/timer_isActive_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/timer_isolate_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/timer_repeat_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/timer_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
kevmoo
Better, right?
6 years, 9 months ago (2014-03-29 06:11:49 UTC) #1
kevmoo
PTAL +sigmund
6 years, 8 months ago (2014-03-31 19:43:41 UTC) #2
Siggi Cherem (dart-lang)
the changes look great to me. I recall that the test infrastructure didn't use to ...
6 years, 8 months ago (2014-03-31 19:52:28 UTC) #3
Siggi Cherem (dart-lang)
https://codereview.chromium.org/218283002/diff/40001/tests/benchmark_smoke/benchmark_smoke_test.dart File tests/benchmark_smoke/benchmark_smoke_test.dart (right): https://codereview.chromium.org/218283002/diff/40001/tests/benchmark_smoke/benchmark_smoke_test.dart#newcode11 tests/benchmark_smoke/benchmark_smoke_test.dart:11: import '../../pkg/expect/lib/expect.dart'; fix this one too?
6 years, 8 months ago (2014-03-31 19:53:09 UTC) #4
kevmoo
PTAL Going with just async tests for now. Roll this out slowly.
6 years, 8 months ago (2014-03-31 21:25:22 UTC) #5
ricow1
LGTM Back in the day we had issues with passing in the package root to ...
6 years, 8 months ago (2014-04-01 06:21:07 UTC) #6
kevmoo
6 years, 8 months ago (2014-04-01 16:12:55 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 manually as r34602 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698