Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 2182783002: Revert of DevTools: cleanup treeoutline expand logic (Closed)

Created:
4 years, 5 months ago by luoe
Modified:
4 years, 4 months ago
Reviewers:
dgozman, lushnikov, allada
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: cleanup treeoutline expand logic (patchset #1 id:1 of https://codereview.chromium.org/2147343002/ ) Reason for revert: [Devtools] Broke header tabs in network tab BUG=630971 Original issue's description: > DevTools: cleanup treeoutline expand logic > > TreeElement.expand() should not need to check that the element has children and > TreeOutline.insertChild() should not automatically expand a child when it is > inserted. ObjectPropertiesSection.js depended on this logic to automatically > expand the Entries property. This CL updates it so that the Entries property is > added before expanded. > > BUG= > > Committed: https://crrev.com/cf5b729f072ba670c7b9966407fb3d47eb2169e7 > Cr-Commit-Position: refs/heads/master@{#407061} TBR=lushnikov@chromium.org,luoe@chromium.org Committed: https://crrev.com/11d703f3d3c135b2feb9b12509cf1ce60cc1f18c Cr-Commit-Position: refs/heads/master@{#407801}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
dgozman
lgtm
4 years, 5 months ago (2016-07-25 22:30:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182783002/1
4 years, 4 months ago (2016-07-26 15:12:10 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 15:16:21 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 15:18:58 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/11d703f3d3c135b2feb9b12509cf1ce60cc1f18c
Cr-Commit-Position: refs/heads/master@{#407801}

Powered by Google App Engine
This is Rietveld 408576698