Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 2182773002: Issue 26787. Report HintCode.OVERRIDE_ON_NON_OVERRIDING_GETTER for non-overriding fields. (Closed)

Created:
4 years, 5 months ago by scheglov
Modified:
4 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -29 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +15 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/hint_code_test.dart View 2 chunks +24 lines, -9 lines 0 comments Download
M pkg/analyzer/test/generated/non_hint_code_test.dart View 3 chunks +52 lines, -20 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 5 months ago (2016-07-25 21:49:36 UTC) #1
pquitslund
lgtm
4 years, 5 months ago (2016-07-25 21:57:39 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 7808f167ec32d5cbf9be129724180c391802a9f3 (presubmit successful).
4 years, 5 months ago (2016-07-25 22:02:34 UTC) #4
Brian Wilkerson
4 years, 4 months ago (2016-07-27 14:15:47 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698