Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2182763003: Revert of Update V8 to version 5.4.246. (Closed)

Created:
4 years, 4 months ago by benwells
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update V8 to version 5.4.246. (patchset #1 id:1 of https://codereview.chromium.org/2181763002/ ) Reason for revert: This has introduced build errors on DrMemory. v8 change that caused this is https://crrev.com/52f2ceb052f63324050c7a098e4398f510b54763. For reference the errors are: gyp: Key 'conditions' repeated at level 11 with key path 'target_defaults.conditions.6.1.target_conditions.0.1.conditions.0.1' while reading C:\b\build\slave\drm-cr\build\src\v8\gypfiles\toolchain.gypi while reading includes of C:\b\build\slave\drm-cr\build\src\v8\src\d8.gyp gyp: Key 'conditions' repeated at level 11 with key path 'target_defaults.conditions.6.1.target_conditions.0.1.conditions.0.1' while reading C:\b\build\slave\drm-cr\build\src\v8\gypfiles\toolchain.gypi while reading includes of C:\b\build\slave\drm-cr\build\src\v8\src\v8.gyp gyp: Key 'conditions' repeated at level 11 with key path 'target_defaults.conditions.6.1.target_conditions.0.1.conditions.0.1' while reading C:\b\build\slave\drm-cr\build\src\v8\gypfiles\toolchain.gypi while reading includes of C:\b\build\slave\drm-cr\build\src\v8\samples\samples.gyp Original issue's description: > Update V8 to version 5.4.246. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/61e64edd..f5146b9b > > Please follow these instructions for assigning/CC'ing issues: > https://github.com/v8/v8/wiki/Triaging%20issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org > > Committed: https://crrev.com/27bd5a607b8dc2f0bf5aec0eaa90f5a3f5ea30b2 > Cr-Commit-Position: refs/heads/master@{#407615} TBR=hablich@chromium.org,littledan@chromium.org,machenbach@chromium.org,vogelheim@chromium.org,v8-autoroll@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
benwells
Created Revert of Update V8 to version 5.4.246.
4 years, 4 months ago (2016-07-26 04:59:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182763003/1
4 years, 4 months ago (2016-07-26 05:00:05 UTC) #3
commit-bot: I haz the power
Failed to apply patch for DEPS: While running git apply --index -3 -p1; error: patch ...
4 years, 4 months ago (2016-07-26 05:00:31 UTC) #5
Michael Achenbach
I'll land a roll with the revert on the V8 side now.
4 years, 4 months ago (2016-07-26 06:33:23 UTC) #6
benwells
4 years, 4 months ago (2016-07-26 06:34:05 UTC) #7
On 2016/07/26 06:33:23, Michael Achenbach (slow) wrote:
> I'll land a roll with the revert on the V8 side now.

Thanks Michael!

Powered by Google App Engine
This is Rietveld 408576698