Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2182693003: Filter GestureFlingStarts with Vx=Vy=0 in RenderWidgetHostViewChildFrame (Closed)

Created:
4 years, 5 months ago by wjmaclean
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Filter GestureFlingStarts with Vx=Vy=0 in RenderWidgetHostViewChildFrame This CL fixes both (1) the renderer crash originally fixed by https://codereview.chromium.org/2165043002, and (2) reverts the part of that CL which prevents ChromeOS from having zero-velocity GestureFlingStarts, which caused a regression in two-finger swipe navigation for touchpad. It also moves the DCHECK from the original CL to a new location which would have prevented the renderer crashes from being introduced in the first place. This CL doesn't include a test, though the test proposed by khmel@ in https://codereview.chromium.org/2168693003 presumably will land shortly after this CL. BUG=627227 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2173603002 Cr-Commit-Position: refs/heads/master@{#407275} (cherry picked from commit d51673024bb1990807d86e8acfbf7759748fbae3) Committed: https://chromium.googlesource.com/chromium/src/+/9fce52f932fd3d1521fb113d61253c0b1482653a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -16 lines) Patch
M content/browser/frame_host/render_widget_host_view_child_frame.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 2 chunks +26 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_input_event_router.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +9 lines, -5 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc View 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
wjmaclean
4 years, 5 months ago (2016-07-25 21:21:04 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9fce52f932fd3d1521fb113d61253c0b1482653a.

Powered by Google App Engine
This is Rietveld 408576698