Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 2182683003: aw: Move thread hop code to ProviderFactory (Closed)

Created:
4 years, 4 months ago by boliu
Modified:
4 years, 4 months ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

aw: Move thread hop code to ProviderFactory So that the thread hopping code can be used from entry points other than WebViewChromium. Large CL, but mostly no-op. Moved these to ProivderFactory: WebViewChromiumRunQueue runBlockingFuture runVoidTaskOnUiThreadBlocking runOnUiThreadBlocking addTask Now FactoryProvider no longer needs to keep a list of WebViewChromiums yet to be started. So remove all that logic along with startYourEngine, and no longer need to drainQueue. Subtle change in behavior is tasks for a single WebViewChromium used to be grouped together and now are all appended to a single queue that's drained at start up. This should not cause problems. BUG=630709 Committed: https://crrev.com/fbfe162dd52f7901535ceb70edf719ef4a692046 Cr-Commit-Position: refs/heads/master@{#407848}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -207 lines) Patch
M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java View 104 chunks +117 lines, -184 lines 0 comments Download
M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java View 5 chunks +73 lines, -23 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
boliu
part 1
4 years, 4 months ago (2016-07-25 20:45:19 UTC) #2
Torne
LGTM - I like this much better than the old code :)
4 years, 4 months ago (2016-07-26 17:09:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182683003/1
4 years, 4 months ago (2016-07-26 17:14:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 17:56:53 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 17:59:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fbfe162dd52f7901535ceb70edf719ef4a692046
Cr-Commit-Position: refs/heads/master@{#407848}

Powered by Google App Engine
This is Rietveld 408576698