Fix an integer overflow in opj_tcd_get_decoded_tile_size().

Fix an integer overflow in opj_tcd_get_decoded_tile_size().

Based on suggested patch by reporter.
BUG=629919
Committed: https://pdfium.googlesource.com/pdfium/+/d8cc503575463ff3d81b22dad292665f2c88911e

[Oliver Chang, 2016-07-25 21:01:51]

Description was changed from

==========
Fix an integer overflow in opj_tcd_get_decoded_tile_size().

Based on suggested patch by reporter.
BUG=chromium:629919
==========

to

==========
Fix an integer overflow in opj_tcd_get_decoded_tile_size().

Based on suggested patch by reporter.
BUG=chromium:629919
==========

[Oliver Chang, 2016-07-25 21:01:51]

ochang@chromium.org changed reviewers:
+ thestig@chromium.org

[Oliver Chang, 2016-07-25 21:01:59]

PTAL.

[Lei Zhang, 2016-07-25 21:20:22]

Description was changed from

==========
Fix an integer overflow in opj_tcd_get_decoded_tile_size().

Based on suggested patch by reporter.
BUG=chromium:629919
==========

to

==========
Fix an integer overflow in opj_tcd_get_decoded_tile_size().

Based on suggested patch by reporter.
BUG=629919
==========

[Lei Zhang, 2016-07-25 21:24:59]

lgtm

I removed the "chromium:" portion of the BUG= line because (a) it's implied on
codereview.chromium.org and (b) some tools, possibly just my local copy of
roll_pdfium.py, don't handle it well.

https://codereview.chromium.org/2182683002/diff/40001/third_party/libopenjpeg...
File third_party/libopenjpeg20/tcd.c (right):

https://codereview.chromium.org/2182683002/diff/40001/third_party/libopenjpeg...
third_party/libopenjpeg20/tcd.c:1153: OPJ_UINT32 l_temp;
Can we declare this inside the for-loop, since it's only used there?

[Oliver Chang, 2016-07-25 21:37:17]

Thanks for reviewing!

I thought that bugdroid doesn't work properly when you don't specify chromium:
for a chromium bug, as it defaults to the pdfium tracker.

https://codereview.chromium.org/2182683002/diff/40001/third_party/libopenjpeg...
File third_party/libopenjpeg20/tcd.c (right):

https://codereview.chromium.org/2182683002/diff/40001/third_party/libopenjpeg...
third_party/libopenjpeg20/tcd.c:1153: OPJ_UINT32 l_temp;
On 2016/07/25 21:24:59, Lei Zhang wrote:
> Can we declare this inside the for-loop, since it's only used there?

The style of openjpeg seems to be to declare all variables at the beginning of
the function. Let's be consistent here?

[Lei Zhang, 2016-07-25 21:40:04]

On 2016/07/25 21:37:17, Oliver Chang wrote:
> Thanks for reviewing!
> 
> I thought that bugdroid doesn't work properly when you don't specify chromium:
> for a chromium bug, as it defaults to the pdfium tracker.

It autolinks correctly right now. I think it defaults to chromium. It's PDFium
(or anything non-chromium) bugs that you explicitly need a project_name: prefix.

>
https://codereview.chromium.org/2182683002/diff/40001/third_party/libopenjpeg...
> File third_party/libopenjpeg20/tcd.c (right):
> 
>
https://codereview.chromium.org/2182683002/diff/40001/third_party/libopenjpeg...
> third_party/libopenjpeg20/tcd.c:1153: OPJ_UINT32 l_temp;
> On 2016/07/25 21:24:59, Lei Zhang wrote:
> > Can we declare this inside the for-loop, since it's only used there?
> 
> The style of openjpeg seems to be to declare all variables at the beginning of
> the function. Let's be consistent here?

Ok, sure. Still LGTM.

[Oliver Chang, 2016-07-25 21:43:16]

The CQ bit was checked by ochang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 21:43:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 21:55:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 21:55:33]

Dry run: This issue passed the CQ dry run.

[Oliver Chang, 2016-07-25 22:09:16]

The CQ bit was checked by ochang@chromium.org

[commit-bot: I haz the power, 2016-07-25 22:09:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 22:09:37]

Description was changed from

==========
Fix an integer overflow in opj_tcd_get_decoded_tile_size().

Based on suggested patch by reporter.
BUG=629919
==========

to

==========
Fix an integer overflow in opj_tcd_get_decoded_tile_size().

Based on suggested patch by reporter.
BUG=629919

Committed:
https://pdfium.googlesource.com/pdfium/+/d8cc503575463ff3d81b22dad292665f2c88...
==========

[commit-bot: I haz the power, 2016-07-25 22:09:39]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/d8cc503575463ff3d81b22dad292665f2c88...