Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2182683002: Fix an integer overflow in opj_tcd_get_decoded_tile_size(). (Closed)

Created:
2 years, 9 months ago by Oliver Chang
Modified:
2 years, 9 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix an integer overflow in opj_tcd_get_decoded_tile_size(). Based on suggested patch by reporter. BUG=629919 Committed: https://pdfium.googlesource.com/pdfium/+/d8cc503575463ff3d81b22dad292665f2c88911e

Patch Set 1 #

Patch Set 2 : minor fix #

Patch Set 3 : another #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -2 lines) Patch
A third_party/libopenjpeg20/0018-tcd_get_decoded_tile_size.patch View 1 2 1 chunk +69 lines, -0 lines 0 comments Download
M third_party/libopenjpeg20/README.pdfium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libopenjpeg20/j2k.c View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/libopenjpeg20/tcd.c View 1 2 3 chunks +14 lines, -2 lines 2 comments Download

Messages

Total messages: 15 (9 generated)
Oliver Chang
PTAL.
2 years, 9 months ago (2016-07-25 21:01:59 UTC) #3
Lei Zhang
lgtm I removed the "chromium:" portion of the BUG= line because (a) it's implied on ...
2 years, 9 months ago (2016-07-25 21:24:59 UTC) #5
Oliver Chang
Thanks for reviewing! I thought that bugdroid doesn't work properly when you don't specify chromium: ...
2 years, 9 months ago (2016-07-25 21:37:17 UTC) #6
Lei Zhang
On 2016/07/25 21:37:17, Oliver Chang wrote: > Thanks for reviewing! > > I thought that ...
2 years, 9 months ago (2016-07-25 21:40:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182683002/40001
2 years, 9 months ago (2016-07-25 22:09:20 UTC) #13
commit-bot: I haz the power
2 years, 9 months ago (2016-07-25 22:09:39 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/d8cc503575463ff3d81b22dad292665f2c88...

Powered by Google App Engine
This is Rietveld 408576698