Issue 2182673003: Avoid crashing if MHTMLGenerationManager::JobFinished is called twice.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2182673003: Avoid crashing if MHTMLGenerationManager::JobFinished is called twice. (Closed)

Created:
4 years, 5 months ago by Łukasz Anforowicz

Modified:
4 years, 5 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2785

Target Ref:
refs/pending/branch-heads/2785

Project:
chromium

Visibility:
Public.

Avoid crashing if MHTMLGenerationManager::JobFinished is called twice. This CL makes sure that MHTMLGenerationManager::JobFinished is idempotent and doesn't do anything when called for a second time. This avoids the crash from the linked bug. BUG=612098 Review-Url: https://codereview.chromium.org/2163073002 Cr-Commit-Position: refs/heads/master@{#407244} (cherry picked from commit a668d7811c2c19662cbeec9e10a3e283292445e5) Committed: https://chromium.googlesource.com/chromium/src/+/7b183ec013bd7217340be9f821307b360a76e79d

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+174 lines, -20 lines)			Patch
M	content/browser/download/docs/save-page-as.md	View	1 chunk	+10 lines, -7 lines	0 comments	Download
M	content/browser/download/mhtml_generation_browsertest.cc	View	3 chunks	+121 lines, -0 lines	0 comments	Download
M	content/browser/download/mhtml_generation_manager.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/browser/download/mhtml_generation_manager.cc	View	10 chunks	+39 lines, -13 lines	0 comments	Download

Total messages: 2 (1 generated)

Łukasz Anforowicz

4 years, 5 months ago (2016-07-25 19:31:23 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7b183ec013bd7217340be9f821307b360a76e79d.