Mark two layout tests as failure for a skia change

Mark two layout tests as failure for a skia change

After this change: https://codereview.chromium.org/2176193002/, canvas
drawImage() API call does bleeding, so these two layout tests will fail.

This CL mark them as failure, and once skia change is committed, we should
update the layout tests.

TBR=junov@chromium.org,schenney@chromium.org
BUG=355305
Committed: https://crrev.com/b005452374a9c5c59b292c448da7d2edf3e7158d
Cr-Commit-Position: refs/heads/master@{#407568}

[xidachen, 2016-07-25 18:49:18]

The CQ bit was checked by xidachen@chromium.org

[commit-bot: I haz the power, 2016-07-25 18:50:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xidachen, 2016-07-25 19:05:35]

Description was changed from

==========
Mark to layout tests as failure for a skia change

After this change: https://codereview.chromium.org/2176193002/, canvas
drawImage() API call does bleeding, so these two layout tests will fail.

This CL mark them as failure, and once skia change is committed, we should
update the layout tests.

TBR=junov@chromium.org,schenney@chromium.org
BUG=355305
==========

to

==========
Mark two layout tests as failure for a skia change

After this change: https://codereview.chromium.org/2176193002/, canvas
drawImage() API call does bleeding, so these two layout tests will fail.

This CL mark them as failure, and once skia change is committed, we should
update the layout tests.

TBR=junov@chromium.org,schenney@chromium.org
BUG=355305
==========

[commit-bot: I haz the power, 2016-07-25 20:43:05]

Description was changed from

==========
Mark two layout tests as failure for a skia change

After this change: https://codereview.chromium.org/2176193002/, canvas
drawImage() API call does bleeding, so these two layout tests will fail.

This CL mark them as failure, and once skia change is committed, we should
update the layout tests.

TBR=junov@chromium.org,schenney@chromium.org
BUG=355305
==========

to

==========
Mark two layout tests as failure for a skia change

After this change: https://codereview.chromium.org/2176193002/, canvas
drawImage() API call does bleeding, so these two layout tests will fail.

This CL mark them as failure, and once skia change is committed, we should
update the layout tests.

TBR=junov@chromium.org,schenney@chromium.org
BUG=355305
==========

[commit-bot: I haz the power, 2016-07-25 20:43:06]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-25 20:45:35]

Description was changed from

==========
Mark two layout tests as failure for a skia change

After this change: https://codereview.chromium.org/2176193002/, canvas
drawImage() API call does bleeding, so these two layout tests will fail.

This CL mark them as failure, and once skia change is committed, we should
update the layout tests.

TBR=junov@chromium.org,schenney@chromium.org
BUG=355305
==========

to

==========
Mark two layout tests as failure for a skia change

After this change: https://codereview.chromium.org/2176193002/, canvas
drawImage() API call does bleeding, so these two layout tests will fail.

This CL mark them as failure, and once skia change is committed, we should
update the layout tests.

TBR=junov@chromium.org,schenney@chromium.org
BUG=355305

Committed: https://crrev.com/b005452374a9c5c59b292c448da7d2edf3e7158d
Cr-Commit-Position: refs/heads/master@{#407568}
==========

[commit-bot: I haz the power, 2016-07-25 20:45:36]

Patchset 1 (id:??) landed as
https://crrev.com/b005452374a9c5c59b292c448da7d2edf3e7158d
Cr-Commit-Position: refs/heads/master@{#407568}

[Justin Novosad, 2016-07-26 14:15:34]

On 2016/07/25 20:45:36, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/b005452374a9c5c59b292c448da7d2edf3e7158d
> Cr-Commit-Position: refs/heads/master@{#407568}

This was not the right way to fold-in a change to skia's behavior.
The way we normally do this is to put a the new skia functionality inside an
#ifdef that masks the feature by default, then we enable it in blink
(SkUserConfig.h) at the same time as we fix-up blink to work properly with the
new functionality (without ever disabling any tests), then we go back to skia to
remove the #define and the old functionality.

[xidachen, 2016-07-26 14:20:03]

On 2016/07/26 14:15:34, Justin Novosad wrote:
> On 2016/07/25 20:45:36, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/b005452374a9c5c59b292c448da7d2edf3e7158d
> > Cr-Commit-Position: refs/heads/master@{#407568}
> 
> This was not the right way to fold-in a change to skia's behavior.
> The way we normally do this is to put a the new skia functionality inside an
> #ifdef that masks the feature by default, then we enable it in blink
> (SkUserConfig.h) at the same time as we fix-up blink to work properly with the
> new functionality (without ever disabling any tests), then we go back to skia
to
> remove the #define and the old functionality.

Oh, I see. Sorry about that. I think I asked jbroman@, and my interpretation was
that we label some test as failure before skia-deps-roll, and change the tests
after skia change is rolled in. Will follow the correct procedure next time.