services/tracing/public/cpp/tracing_impl.h - Issue 2182643003: Remove shell::Connection* parameter to InterfaceFactory<T>::Create()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/tracing/public/cpp/tracing_impl.h

Issue 2182643003: Remove shell::Connection* parameter to InterfaceFactory<T>::Create() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« services/shell/public/cpp/lib/interface_registry.cc ('K') | « services/shell/tests/shutdown/shutdown_service_app.cc ('k') | services/tracing/public/cpp/tracing_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: services/tracing/public/cpp/tracing_impl.h

diff --git a/services/tracing/public/cpp/tracing_impl.h b/services/tracing/public/cpp/tracing_impl.h

index 3408d820d54397dc303a22ef1afe99368a80e51d..e8f2fee30c76b9d2fa548a7eaca9b850bf3f3379 100644

--- a/services/tracing/public/cpp/tracing_impl.h

+++ b/services/tracing/public/cpp/tracing_impl.h

@@ -29,7 +29,7 @@ class TracingImpl : public shell::InterfaceFactory<tracing::TraceProvider> {

private:

// InterfaceFactory<tracing::TraceProvider> implementation.

- void Create(shell::Connection* connection,

+ void Create(const shell::Identity& remote_identity,

tracing::TraceProviderRequest request) override;

std::unique_ptr<shell::Connection> connection_;