services/shell/public/cpp/lib/callback_binder.h - Issue 2182643003: Remove shell::Connection* parameter to InterfaceFactory<T>::Create()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/shell/public/cpp/lib/callback_binder.h

Issue 2182643003: Remove shell::Connection* parameter to InterfaceFactory<T>::Create() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « services/shell/public/cpp/interface_registry.h ('k') | services/shell/public/cpp/lib/callback_binder.cc » ('j') | services/shell/public/cpp/lib/interface_registry.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: services/shell/public/cpp/lib/callback_binder.h

diff --git a/services/shell/public/cpp/lib/callback_binder.h b/services/shell/public/cpp/lib/callback_binder.h

index c960e070b4d8fd6bbde6e5c48b4bcb82c713c149..87cb043922d151b65719acae22b743e9c90c380f 100644

--- a/services/shell/public/cpp/lib/callback_binder.h

+++ b/services/shell/public/cpp/lib/callback_binder.h

@@ -30,7 +30,7 @@ class CallbackBinder : public InterfaceBinder {

private:

// InterfaceBinder:

void BindInterface(

- Connection* connection,

+ const Identity& remote_identity,

const std::string& interface_name,

mojo::ScopedMessagePipeHandle handle) override {

mojo::InterfaceRequest<Interface> request =

@@ -67,9 +67,9 @@ class GenericCallbackBinder : public InterfaceBinder {

private:

// InterfaceBinder:

- void BindInterface(Connection* connection,

- const std::string& interface_name,

- mojo::ScopedMessagePipeHandle handle) override;

+ void BindInterface(const shell::Identity& remote_identity,

+ const std::string& interface_name,

+ mojo::ScopedMessagePipeHandle handle) override;

static void RunCallbackOnTaskRunner(

const BindCallback& callback,