services/shell/public/cpp/interface_binder.h - Issue 2182643003: Remove shell::Connection* parameter to InterfaceFactory<T>::Create()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/shell/public/cpp/interface_binder.h

Issue 2182643003: Remove shell::Connection* parameter to InterfaceFactory<T>::Create() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « services/shell/background/tests/test_service.cc ('k') | services/shell/public/cpp/interface_factory.h » ('j') | services/shell/public/cpp/lib/interface_registry.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: services/shell/public/cpp/interface_binder.h

diff --git a/services/shell/public/cpp/interface_binder.h b/services/shell/public/cpp/interface_binder.h

index 9dec4addde66da46954cf633dc20bc9f1e21f9f4..4d864351415ea1bf6d3343246ae7d7f372bd2a6e 100644

--- a/services/shell/public/cpp/interface_binder.h

+++ b/services/shell/public/cpp/interface_binder.h

@@ -11,7 +11,7 @@

namespace shell {

-class Connection;

+class Identity;

class InterfaceBinder {

public:

@@ -20,7 +20,7 @@ class InterfaceBinder {

// Asks the InterfaceBinder to bind an implementation of the specified

// interface to the request passed via |handle|. If the InterfaceBinder binds

// an implementation it must take ownership of the request handle.

- virtual void BindInterface(Connection* connection,

+ virtual void BindInterface(const Identity& remote_identity,

const std::string& interface_name,

mojo::ScopedMessagePipeHandle handle) = 0;

};