mash/catalog_viewer/catalog_viewer.cc - Issue 2182643003: Remove shell::Connection* parameter to InterfaceFactory<T>::Create()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mash/catalog_viewer/catalog_viewer.cc

Issue 2182643003: Remove shell::Connection* parameter to InterfaceFactory<T>::Create() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mash/catalog_viewer/catalog_viewer.h ('k') | mash/example/views_examples/views_examples_application_delegate.h » ('j') | services/shell/public/cpp/lib/interface_registry.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mash/catalog_viewer/catalog_viewer.cc

diff --git a/mash/catalog_viewer/catalog_viewer.cc b/mash/catalog_viewer/catalog_viewer.cc

index a832beb814aa21007c55ecb15a4db0d4607fbc0b..0a622da3d6f43f62389f3cf19bed25cacd9d8fb5 100644

--- a/mash/catalog_viewer/catalog_viewer.cc

+++ b/mash/catalog_viewer/catalog_viewer.cc

@@ -199,7 +199,7 @@ void CatalogViewer::Launch(uint32_t what, mojom::LaunchMode how) {

windows_.push_back(window);

}

-void CatalogViewer::Create(shell::Connection* connection,

+void CatalogViewer::Create(const shell::Identity& remote_identity,

mojom::LaunchableRequest request) {

bindings_.AddBinding(this, std::move(request));

}