mash/browser/browser.h - Issue 2182643003: Remove shell::Connection* parameter to InterfaceFactory<T>::Create()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mash/browser/browser.h

Issue 2182643003: Remove shell::Connection* parameter to InterfaceFactory<T>::Create() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/mus/render_widget_window_tree_client_factory.cc ('k') | mash/browser/browser.cc » ('j') | services/shell/public/cpp/lib/interface_registry.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mash/browser/browser.h

diff --git a/mash/browser/browser.h b/mash/browser/browser.h

index 9e097849cdb7948978484c33f71f86e38a449154..7a4271b6adbfabd7daba0d6920ae053d9708ae2d 100644

--- a/mash/browser/browser.h

+++ b/mash/browser/browser.h

@@ -52,7 +52,7 @@ class Browser : public shell::Service,

void Launch(uint32_t what, mojom::LaunchMode how) override;

// shell::InterfaceFactory<mojom::Launchable>:

- void Create(shell::Connection* connection,

+ void Create(const shell::Identity& remote_identity,

mojom::LaunchableRequest request) override;

shell::Connector* connector_ = nullptr;