Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 2182633010: Revert of MIPS: Fix mksnapshot on big-endian. (Closed)

Created:
4 years, 4 months ago by Michael Achenbach
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of MIPS: Fix mksnapshot on big-endian. (patchset #3 id:40001 of https://codereview.chromium.org/2172653002/ ) Reason for revert: Blocks the roll: https://codereview.chromium.org/2189443003/ Doesn't work with the last chromium gyp bot. Original issue's description: > MIPS: Fix mksnapshot on big-endian. > > Paritally revert standalone.gypi changes in a451bd1a687987a7056d7847ba14aefd195dd760 and introduce a new separate variable for the mkpeephole. > > On big-endian MIPS, qemu is used to build the snapshot, > because there's no simulator support for big-endian MIPS. > > BUG= > > Committed: https://crrev.com/928d2395c3fdf836cf9961cde96e6b274a6b1e20 > Cr-Commit-Position: refs/heads/master@{#38103} TBR=oth@chromium.org,machenbach@google.com,akos.palfi@imgtec.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/366b00cfbe401ccc17d31f2e51bcbef0a3a4bb05 Cr-Commit-Position: refs/heads/master@{#38108}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -16 lines) Patch
M gypfiles/standalone.gypi View 1 chunk +1 line, -12 lines 0 comments Download
M src/v8.gyp View 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of MIPS: Fix mksnapshot on big-endian.
4 years, 4 months ago (2016-07-27 19:08:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182633010/1
4 years, 4 months ago (2016-07-27 19:08:55 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 19:09:08 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 19:10:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/366b00cfbe401ccc17d31f2e51bcbef0a3a4bb05
Cr-Commit-Position: refs/heads/master@{#38108}

Powered by Google App Engine
This is Rietveld 408576698