Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2182633008: [PCv2] update reference to loadingMetric (Closed)

Created:
4 years, 4 months ago by kouhei (in TOK)
Modified:
4 years, 4 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[PCv2] update reference to loadingMetric https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/5ff2f73d8591c087ffcd023149d7c413304b008f renamed the firstPaintMetric to loadingMetric. This CL updates the reference in PCv2 telemetry benchmark BUG=630278 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/7844d5bffe6f823ab4cc7a74417596d116748415 Cr-Commit-Position: refs/heads/master@{#408081}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/perf/benchmarks/page_cycler_v2.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
kouhei (in TOK)
4 years, 4 months ago (2016-07-27 06:49:56 UTC) #5
nednguyen
lgtm
4 years, 4 months ago (2016-07-27 09:21:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182633008/1
4 years, 4 months ago (2016-07-27 09:22:11 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 09:25:24 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 09:27:04 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7844d5bffe6f823ab4cc7a74417596d116748415
Cr-Commit-Position: refs/heads/master@{#408081}

Powered by Google App Engine
This is Rietveld 408576698