chrome/browser/chrome_content_browser_client.h - Issue 2182633007: Avoid using ContentBrowserClient::IsIllegalOrigin in ResourceDispatcherHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_content_browser_client.h

Issue 2182633007: Avoid using ContentBrowserClient::IsIllegalOrigin in ResourceDispatcherHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove the IsIllegalOrigin function from ContentBrowserClient Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browser_process_impl.cc ('k') | chrome/browser/chrome_content_browser_client.cc » ('j') | content/browser/loader/resource_dispatcher_host_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chrome_content_browser_client.h

diff --git a/chrome/browser/chrome_content_browser_client.h b/chrome/browser/chrome_content_browser_client.h

index 546792e448e4c7556edf12f528fdee9d21c0b0eb..2bce582a3dc1f73029f2a937aa34d1ce2273df33 100644

--- a/chrome/browser/chrome_content_browser_client.h

+++ b/chrome/browser/chrome_content_browser_client.h

@@ -87,9 +87,6 @@ class ChromeContentBrowserClient : public content::ContentBrowserClient {

bool IsHandledURL(const GURL& url) override;

bool CanCommitURL(content::RenderProcessHost* process_host,

const GURL& url) override;

- bool IsIllegalOrigin(content::ResourceContext* resource_context,

- int child_process_id,

- const GURL& origin) override;

bool ShouldAllowOpenURL(content::SiteInstance* site_instance,

const GURL& url) override;

void OverrideOpenURLParams(content::SiteInstance* site_instance,