Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: chrome/browser/extensions/chrome_content_browser_client_extensions_part.h

Issue 2182633007: Avoid using ContentBrowserClient::IsIllegalOrigin in ResourceDispatcherHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compile errors Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/chrome_content_browser_client_extensions_part.h
diff --git a/chrome/browser/extensions/chrome_content_browser_client_extensions_part.h b/chrome/browser/extensions/chrome_content_browser_client_extensions_part.h
index 8982d5271a418fac9dfd9a473c7c5c9d4b32fb00..2b7650f67991fded8f8d479b1cc19cd6991b7f3c 100644
--- a/chrome/browser/extensions/chrome_content_browser_client_extensions_part.h
+++ b/chrome/browser/extensions/chrome_content_browser_client_extensions_part.h
@@ -16,6 +16,9 @@ class VpnServiceProxy;
namespace extensions {
+class Extension;
+class InfoMap;
+
// Implements the extensions portion of ChromeContentBrowserClient.
class ChromeContentBrowserClientExtensionsPart
: public ChromeContentBrowserClientParts {
@@ -34,9 +37,6 @@ class ChromeContentBrowserClientExtensionsPart
const GURL& effective_site_url);
static bool CanCommitURL(content::RenderProcessHost* process_host,
const GURL& url);
- static bool IsIllegalOrigin(content::ResourceContext* resource_context,
- int child_process_id,
- const GURL& origin);
static bool IsSuitableHost(Profile* profile,
content::RenderProcessHost* process_host,
const GURL& site_url);
@@ -92,6 +92,22 @@ class ChromeContentBrowserClientExtensionsPart
content::RenderProcessHost* process,
Profile* profile) override;
+ // Helper functions to register and unregister an extension process. Invoked
jam 2016/08/02 17:01:46 nit: since they're just static private methods, no
ananta 2016/08/02 22:28:27 Done.
+ // on the IO thread.
+ static void RegisterExtensionProcessHelper(
+ InfoMap* info_map,
+ const Extension* extension,
+ int process_id,
+ int site_instance_id,
+ const content::ResourceContext* context);
+
+ static void UnregisterExtensionProcessHelper(
+ InfoMap* info_map,
+ const Extension* extension,
+ int process_id,
+ int site_instance_id,
+ const content::ResourceContext* context);
+
DISALLOW_COPY_AND_ASSIGN(ChromeContentBrowserClientExtensionsPart);
};

Powered by Google App Engine
This is Rietveld 408576698