content/browser/security_exploit_browsertest.cc - Issue 2182633007: Avoid using ContentBrowserClient::IsIllegalOrigin in ResourceDispatcherHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/security_exploit_browsertest.cc

Issue 2182633007: Avoid using ContentBrowserClient::IsIllegalOrigin in ResourceDispatcherHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix compile failures Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/loader/resource_dispatcher_host_impl.cc ('K') | « content/browser/loader/resource_dispatcher_host_impl.cc ('k') | content/public/browser/resource_dispatcher_host.h » ('j') | content/public/browser/resource_dispatcher_host.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/security_exploit_browsertest.cc

diff --git a/content/browser/security_exploit_browsertest.cc b/content/browser/security_exploit_browsertest.cc

index f9d6d7f935e50d0255017c7e2c568db8317eb30a..49321af38911a7a28c1d0f93948afd390aeb5d86 100644

--- a/content/browser/security_exploit_browsertest.cc

+++ b/content/browser/security_exploit_browsertest.cc

@@ -426,6 +426,12 @@ IN_PROC_BROWSER_TEST_F(SecurityExploitBrowserTest, InvalidOriginHeaders) {

NavigateToURL(shell(), web_url);

RenderFrameHost* web_rfh = shell()->web_contents()->GetMainFrame();

+ ResourceDispatcherHost::Get()->AddSchemeForAccessCheck("https");

+ ResourceDispatcherHost::Get()->AddOriginAccessInformation(

+ shell()->web_contents()->GetBrowserContext()->GetResourceContext(),

+ "https://isolated.bar.com");

// Web processes cannot make XHRs with chrome:// Origin headers.

{

RenderProcessHostWatcher web_process_killed(