Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 2182633002: Fix networking_private IDL (Closed)

Created:
4 years, 5 months ago by stevenjb
Modified:
4 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org, jlklein+watch-closure_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix networking_private IDL Minor fixes to the networkingPrivate IDL. This produces a non-fatal but confusing error in the Settings UI. ManagedDOMString[] is invalid, ManagedDOMStringList should be used instead. (The managed property should be an objetc with each entry, e.g. 'Active', 'DevicePolicy', etc, as a separate array of strings, instead of an array of objects). BUG=none Committed: https://crrev.com/984a730360486f3a02130e81d1ebe6daf036bf52 Cr-Commit-Position: refs/heads/master@{#407583}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M extensions/common/api/networking_private.idl View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/closure_compiler/externs/networking_private.js View 2 chunks +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
stevenjb
4 years, 5 months ago (2016-07-25 18:26:53 UTC) #3
asargent_no_longer_on_chrome
nit: CL description should be re-wrapped (I think at 72 chars?) otherwise lgtm
4 years, 5 months ago (2016-07-25 20:13:52 UTC) #4
stevenjb
On 2016/07/25 20:13:52, Antony Sargent wrote: > nit: CL description should be re-wrapped (I think ...
4 years, 5 months ago (2016-07-25 20:17:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182633002/1
4 years, 5 months ago (2016-07-25 20:18:36 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 21:27:42 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 21:30:49 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/984a730360486f3a02130e81d1ebe6daf036bf52
Cr-Commit-Position: refs/heads/master@{#407583}

Powered by Google App Engine
This is Rietveld 408576698