Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2182603003: Just pass the draw context to paint conversion (Closed)

Created:
4 years, 4 months ago by Brian Osman
Modified:
4 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Just pass the draw context to paint conversion Concentrate on using draw context functionality to answer gamma and color related queries in more places. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2182603003 Committed: https://skia.googlesource.com/skia/+/8fe485b793f6b3c286700988138e1395b0d33487

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -135 lines) Patch
M gm/constcolorprocessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/GrDrawContext.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/GrBlurUtils.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 18 chunks +32 lines, -66 lines 0 comments Download
M src/gpu/SkGpuDevice_drawTexture.cpp View 1 chunk +3 lines, -6 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 5 chunks +23 lines, -33 lines 0 comments Download
M src/gpu/SkGrPriv.h View 3 chunks +10 lines, -15 lines 0 comments Download
M src/gpu/text/GrAtlasTextContext.cpp View 3 chunks +6 lines, -5 lines 1 comment Download
M src/gpu/text/GrStencilAndCoverTextContext.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M tools/gpu/GrTest.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
Brian Osman
My plan is to eliminate the gamma-correct flag from SkSurfaceProps, to eliminate API redundancy. This ...
4 years, 4 months ago (2016-07-25 17:32:25 UTC) #7
bsalomon
lgtm
4 years, 4 months ago (2016-07-25 19:22:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182603003/20001
4 years, 4 months ago (2016-07-25 19:30:41 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/8fe485b793f6b3c286700988138e1395b0d33487
4 years, 4 months ago (2016-07-25 19:31:54 UTC) #16
robertphillips
lgtm too https://codereview.chromium.org/2182603003/diff/20001/src/gpu/text/GrAtlasTextContext.cpp File src/gpu/text/GrAtlasTextContext.cpp (right): https://codereview.chromium.org/2182603003/diff/20001/src/gpu/text/GrAtlasTextContext.cpp#newcode391 src/gpu/text/GrAtlasTextContext.cpp:391: // Setup dummy SkPaint / GrPaint / ...
4 years, 4 months ago (2016-07-25 19:32:02 UTC) #17
Brian Osman
4 years, 4 months ago (2016-07-25 19:44:13 UTC) #18
Message was sent while issue was closed.
On 2016/07/25 19:32:02, robertphillips wrote:
> lgtm too
> 
>
https://codereview.chromium.org/2182603003/diff/20001/src/gpu/text/GrAtlasTex...
> File src/gpu/text/GrAtlasTextContext.cpp (right):
> 
>
https://codereview.chromium.org/2182603003/diff/20001/src/gpu/text/GrAtlasTex...
> src/gpu/text/GrAtlasTextContext.cpp:391: // Setup dummy SkPaint / GrPaint /
> GrDrawContext
> Can this be 64x64 ?

It probably could be. The test code below is generating blobs with positions
that are roughly in the
(0, 1024) range, and I didn't want to alter anything (even if it's just a matter
of early culling).
May not matter, since this seems to be largely a structural test?

Powered by Google App Engine
This is Rietveld 408576698