Bitrate prober and paced sender improvements

webrtc/modules/pacing/bitrate_prober_unittest.cc

 /*
  *  Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 47 matching lines @@
   EXPECT_FALSE(prober.IsProbing());
   int64_t now_ms = 0;
   EXPECT_EQ(-1, prober.TimeUntilNextProbe(now_ms));
 
   prober.SetEnabled(true);
   EXPECT_FALSE(prober.IsProbing());
 
   prober.OnIncomingPacket(300000, 1000, now_ms);
   EXPECT_TRUE(prober.IsProbing());
   EXPECT_EQ(0, prober.TimeUntilNextProbe(now_ms));
+  prober.PacketSent(now_ms, 1000);

[stefan-webrtc, 2016/07/29 07:12:07]

Did you add this to test the inactivity threshold?

[Irfan, 2016/08/01 18:29:47]

Yes, this is necessary (and makes sense in the flow) for the test with the
changes in TimeUntilNextProbe().

   // Let time pass, no large enough packets put into prober.
   now_ms += 6000;
   EXPECT_EQ(-1, prober.TimeUntilNextProbe(now_ms));
   // Insert a small packet, not a candidate for probing.
   prober.OnIncomingPacket(300000, 100, now_ms);
   prober.PacketSent(now_ms, 100);
   EXPECT_EQ(-1, prober.TimeUntilNextProbe(now_ms));
   // Insert a large-enough packet after downtime while probing should reset to
   // perform a new probe since the requested one didn't finish.
   prober.OnIncomingPacket(300000, 1000, now_ms);
   EXPECT_EQ(0, prober.TimeUntilNextProbe(now_ms));
   prober.PacketSent(now_ms, 1000);
   // Next packet should be part of new probe and be sent with non-zero delay.
   prober.OnIncomingPacket(300000, 1000, now_ms);
   EXPECT_GT(prober.TimeUntilNextProbe(now_ms), 0);
 }
 
 TEST(BitrateProberTest, DoesntInitializeProbingForSmallPackets) {
   BitrateProber prober;
   prober.SetEnabled(true);
   EXPECT_FALSE(prober.IsProbing());
 
   prober.OnIncomingPacket(300000, 100, 0);
   EXPECT_FALSE(prober.IsProbing());
 }
 
 }  // namespace webrtc