Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2140)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2182593004: Issue 26747. Report HintCode.UNDEFINED_SHOWN_NAME, but not HintCode.UNUSED_SHOWN_NAME for unresolve… (Closed)

Created:
4 years, 4 months ago by scheglov
Modified:
4 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Issue 26747. Report HintCode.UNDEFINED_SHOWN_NAME, but not HintCode.UNUSED_SHOWN_NAME for unresolved shown names. R=pquitslund@google.com, brianwilkerson@google.com, srawlins@google.com BUG= https://github.com/dart-lang/sdk/issues/26747 Committed: https://github.com/dart-lang/sdk/commit/f4b1d502f3fa771f1e87a136d5c79dcd3cc3d63a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
scheglov
4 years, 4 months ago (2016-07-26 16:13:45 UTC) #1
pquitslund
lgtm
4 years, 4 months ago (2016-07-26 17:15:26 UTC) #3
scheglov
Committed patchset #1 (id:1) manually as f4b1d502f3fa771f1e87a136d5c79dcd3cc3d63a (presubmit successful).
4 years, 4 months ago (2016-07-26 17:36:35 UTC) #5
Brian Wilkerson
4 years, 4 months ago (2016-07-27 14:53:49 UTC) #6
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698