Change implementation of resize ImageBitmap to meet specs

Change implementation of resize ImageBitmap to meet specs

In a previous CL: https://codereview.chromium.org/2035113002, the
implementation of resize options for ImageBitmap follows the procedure
of resize the input and then crop the resized input. The specs recently
changed here: https://github.com/whatwg/html/pull/1546, where now we
should crop the input first and then scale the cropped input.

This CL changes the implementation. The change is actually quite simple,
we let parsedOption.cropRect() to keep the information of the cropRect
specified by the user, and let parsedOption.resizeWidth(Height) be the
resizeWidth && resizeHeight specified by the user. In the cropImage, we
only need to change the srcRect and dstRect when we do
SkCanvas::drawImageRect.

Layout test has been updated to account for this change.

BUG=627855
Committed: https://crrev.com/e41056398cca63a760554d3ae7a63857bca93214
Cr-Commit-Position: refs/heads/master@{#407807}

[xidachen, 2016-07-25 17:25:29]

Description was changed from

==========
Change implementation of resize ImageBitmap to meet specs

In a previous CL: https://codereview.chromium.org/2035113002, the
implementation of resize options for ImageBitmap follows the procedure
of resize the input and then crop the resized input. The specs recently
changed here: https://github.com/whatwg/html/pull/1546, where now we
should crop the input first and then scale the cropped input.

This CL changes the implementation. The change is actually quite simple,
we let parsedOption.cropRect() to keep the information of the cropRect
specified by the user, and let parsedOption.resizeWidth(Height) be the
resizeWidth && resizeHeight specified by the user. In the cropImage, we
only need to change the srcRect and dstRect when we do
SkCanvas::drawImageRect.

BUG=627855
==========

to

==========
Change implementation of resize ImageBitmap to meet specs

In a previous CL: https://codereview.chromium.org/2035113002, the
implementation of resize options for ImageBitmap follows the procedure
of resize the input and then crop the resized input. The specs recently
changed here: https://github.com/whatwg/html/pull/1546, where now we
should crop the input first and then scale the cropped input.

This CL changes the implementation. The change is actually quite simple,
we let parsedOption.cropRect() to keep the information of the cropRect
specified by the user, and let parsedOption.resizeWidth(Height) be the
resizeWidth && resizeHeight specified by the user. In the cropImage, we
only need to change the srcRect and dstRect when we do
SkCanvas::drawImageRect.

Layout test has been updated to account for this change.

BUG=627855
==========

[xidachen, 2016-07-25 17:25:29]

xidachen@chromium.org changed reviewers:
+ junov@chromium.org

[xidachen, 2016-07-25 17:43:39]

PTAL

[Justin Novosad, 2016-07-25 18:03:10]

https://codereview.chromium.org/2182583002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/ImageBitmap.cpp (right):

https://codereview.chromium.org/2182583002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/ImageBitmap.cpp:215: SkImageInfo info =
SkImageInfo::Make(parsedOptions.shouldScaleInput ? parsedOptions.resizeWidth :
parsedOptions.cropRect.width(),
This ternary operation is not necessary. 
Reason: If shouldScaleInput is false then we know that cropRect.width() ==
resizeWidth, so you can just use resizeWidth in either case,

https://codereview.chromium.org/2182583002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/ImageBitmap.cpp:216:
parsedOptions.shouldScaleInput ? parsedOptions.resizeHeight :
parsedOptions.cropRect.height(), kN32_SkColorType, kUnpremul_SkAlphaType);
same here.

https://codereview.chromium.org/2182583002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/ImageBitmap.cpp:247: sk_sp<SkSurface>
surface = SkSurface::MakeRasterN32Premul(parsedOptions.shouldScaleInput ?
parsedOptions.resizeWidth : parsedOptions.cropRect.width(),
same here.

https://codereview.chromium.org/2182583002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/ImageBitmap.cpp:248:
parsedOptions.shouldScaleInput ? parsedOptions.resizeHeight :
parsedOptions.cropRect.height());
same here.

[xidachen, 2016-07-25 19:02:02]

https://codereview.chromium.org/2182583002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/ImageBitmap.cpp (right):

https://codereview.chromium.org/2182583002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/ImageBitmap.cpp:215: SkImageInfo info =
SkImageInfo::Make(parsedOptions.shouldScaleInput ? parsedOptions.resizeWidth :
parsedOptions.cropRect.width(),
On 2016/07/25 18:03:10, Justin Novosad wrote:
> This ternary operation is not necessary. 
> Reason: If shouldScaleInput is false then we know that cropRect.width() ==
> resizeWidth, so you can just use resizeWidth in either case,

Good catch, changes are made. Thanks.

https://codereview.chromium.org/2182583002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/ImageBitmap.cpp:216:
parsedOptions.shouldScaleInput ? parsedOptions.resizeHeight :
parsedOptions.cropRect.height(), kN32_SkColorType, kUnpremul_SkAlphaType);
On 2016/07/25 18:03:10, Justin Novosad wrote:
> same here.

Done.

https://codereview.chromium.org/2182583002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/ImageBitmap.cpp:247: sk_sp<SkSurface>
surface = SkSurface::MakeRasterN32Premul(parsedOptions.shouldScaleInput ?
parsedOptions.resizeWidth : parsedOptions.cropRect.width(),
On 2016/07/25 18:03:10, Justin Novosad wrote:
> same here.

Done.

https://codereview.chromium.org/2182583002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/ImageBitmap.cpp:248:
parsedOptions.shouldScaleInput ? parsedOptions.resizeHeight :
parsedOptions.cropRect.height());
On 2016/07/25 18:03:10, Justin Novosad wrote:
> same here.

Done.

[Justin Novosad, 2016-07-26 14:09:58]

lgtm

[xidachen, 2016-07-26 14:10:15]

The CQ bit was checked by xidachen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 14:10:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 15:28:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 15:28:19]

Dry run: This issue passed the CQ dry run.

[xidachen, 2016-07-26 15:30:31]

The CQ bit was checked by xidachen@chromium.org

[commit-bot: I haz the power, 2016-07-26 15:30:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 15:35:03]

Description was changed from

==========
Change implementation of resize ImageBitmap to meet specs

In a previous CL: https://codereview.chromium.org/2035113002, the
implementation of resize options for ImageBitmap follows the procedure
of resize the input and then crop the resized input. The specs recently
changed here: https://github.com/whatwg/html/pull/1546, where now we
should crop the input first and then scale the cropped input.

This CL changes the implementation. The change is actually quite simple,
we let parsedOption.cropRect() to keep the information of the cropRect
specified by the user, and let parsedOption.resizeWidth(Height) be the
resizeWidth && resizeHeight specified by the user. In the cropImage, we
only need to change the srcRect and dstRect when we do
SkCanvas::drawImageRect.

Layout test has been updated to account for this change.

BUG=627855
==========

to

==========
Change implementation of resize ImageBitmap to meet specs

In a previous CL: https://codereview.chromium.org/2035113002, the
implementation of resize options for ImageBitmap follows the procedure
of resize the input and then crop the resized input. The specs recently
changed here: https://github.com/whatwg/html/pull/1546, where now we
should crop the input first and then scale the cropped input.

This CL changes the implementation. The change is actually quite simple,
we let parsedOption.cropRect() to keep the information of the cropRect
specified by the user, and let parsedOption.resizeWidth(Height) be the
resizeWidth && resizeHeight specified by the user. In the cropImage, we
only need to change the srcRect and dstRect when we do
SkCanvas::drawImageRect.

Layout test has been updated to account for this change.

BUG=627855
==========

[commit-bot: I haz the power, 2016-07-26 15:35:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-26 15:37:26]

Description was changed from

==========
Change implementation of resize ImageBitmap to meet specs

In a previous CL: https://codereview.chromium.org/2035113002, the
implementation of resize options for ImageBitmap follows the procedure
of resize the input and then crop the resized input. The specs recently
changed here: https://github.com/whatwg/html/pull/1546, where now we
should crop the input first and then scale the cropped input.

This CL changes the implementation. The change is actually quite simple,
we let parsedOption.cropRect() to keep the information of the cropRect
specified by the user, and let parsedOption.resizeWidth(Height) be the
resizeWidth && resizeHeight specified by the user. In the cropImage, we
only need to change the srcRect and dstRect when we do
SkCanvas::drawImageRect.

Layout test has been updated to account for this change.

BUG=627855
==========

to

==========
Change implementation of resize ImageBitmap to meet specs

In a previous CL: https://codereview.chromium.org/2035113002, the
implementation of resize options for ImageBitmap follows the procedure
of resize the input and then crop the resized input. The specs recently
changed here: https://github.com/whatwg/html/pull/1546, where now we
should crop the input first and then scale the cropped input.

This CL changes the implementation. The change is actually quite simple,
we let parsedOption.cropRect() to keep the information of the cropRect
specified by the user, and let parsedOption.resizeWidth(Height) be the
resizeWidth && resizeHeight specified by the user. In the cropImage, we
only need to change the srcRect and dstRect when we do
SkCanvas::drawImageRect.

Layout test has been updated to account for this change.

BUG=627855

Committed: https://crrev.com/e41056398cca63a760554d3ae7a63857bca93214
Cr-Commit-Position: refs/heads/master@{#407807}
==========

[commit-bot: I haz the power, 2016-07-26 15:37:27]

Patchset 2 (id:??) landed as
https://crrev.com/e41056398cca63a760554d3ae7a63857bca93214
Cr-Commit-Position: refs/heads/master@{#407807}