Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2182563003: [gn] Switch arm64 bots to gn (Closed)

Created:
4 years, 4 months ago by Michael Achenbach
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Switch arm64 bots to gn BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/0bb05780b3ac4d5f0d917328e98ce9299225d262 Cr-Commit-Position: refs/heads/master@{#38082}

Patch Set 1 #

Patch Set 2 : [gn] Switch arm64 bots to gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -15 lines) Patch
M infra/mb/mb_config.pyl View 1 5 chunks +19 lines, -15 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Michael Achenbach
PTAL. I'm not seeing any red flags here. Comparison links: https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim/builds/2136/steps/compare%20build%20flags%20%28fyi%29/logs/stdio https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20debug/builds/1759/steps/compare%20build%20flags%20%28fyi%29/logs/stdio Similar to arm ...
4 years, 4 months ago (2016-07-27 07:28:33 UTC) #2
vogelheim
lgtm
4 years, 4 months ago (2016-07-27 07:46:47 UTC) #5
jochen (gone - plz use gerrit)
lgtm
4 years, 4 months ago (2016-07-27 07:58:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182563003/20001
4 years, 4 months ago (2016-07-27 08:04:47 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-27 08:06:25 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 08:21:12 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0bb05780b3ac4d5f0d917328e98ce9299225d262
Cr-Commit-Position: refs/heads/master@{#38082}

Powered by Google App Engine
This is Rietveld 408576698