Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Issue 2182563002: [Android] Add heartbeat of platform mode perf test runner. (Closed)

Created:
4 years, 5 months ago by rnephew (Reviews Here)
Modified:
4 years, 5 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add heartbeat of platform mode perf test runner. Extremely long running tests can cause timeouts due to lack of output. This adds a heartbeat message to stop that while tests are still running. BUG=615157, 630640 Committed: https://crrev.com/e8555d3785393f8bf04579226a9e39f4e574c599 Cr-Commit-Position: refs/heads/master@{#407576}

Patch Set 1 #

Total comments: 2

Patch Set 2 : add comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
M build/android/pylib/local/device/local_device_perf_test_run.py View 1 6 chunks +43 lines, -0 lines 1 comment Download

Messages

Total messages: 14 (7 generated)
rnephew (Reviews Here)
4 years, 5 months ago (2016-07-25 16:51:34 UTC) #3
mikecase (-- gone --)
cool, lgtm. This seems more general than to just perf tests though. So might want ...
4 years, 5 months ago (2016-07-25 17:01:28 UTC) #4
rnephew (Reviews Here)
https://codereview.chromium.org/2182563002/diff/20001/build/android/pylib/local/device/local_device_perf_test_run.py File build/android/pylib/local/device/local_device_perf_test_run.py (right): https://codereview.chromium.org/2182563002/diff/20001/build/android/pylib/local/device/local_device_perf_test_run.py#newcode33 build/android/pylib/local/device/local_device_perf_test_run.py:33: def __init__(self, shard, wait_time=60*10): On 2016/07/25 17:01:27, mikecase wrote: ...
4 years, 5 months ago (2016-07-25 17:06:42 UTC) #5
jbudorick
lgtm w/ optional stuff https://codereview.chromium.org/2182563002/diff/40001/build/android/pylib/local/device/local_device_perf_test_run.py File build/android/pylib/local/device/local_device_perf_test_run.py (right): https://codereview.chromium.org/2182563002/diff/40001/build/android/pylib/local/device/local_device_perf_test_run.py#newcode31 build/android/pylib/local/device/local_device_perf_test_run.py:31: class HeartBeat(object): It'd be nice ...
4 years, 5 months ago (2016-07-25 19:57:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182563002/40001
4 years, 5 months ago (2016-07-25 19:59:18 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 5 months ago (2016-07-25 21:18:04 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 21:20:02 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e8555d3785393f8bf04579226a9e39f4e574c599
Cr-Commit-Position: refs/heads/master@{#407576}

Powered by Google App Engine
This is Rietveld 408576698