components/flags_ui/flags_state_unittest.cc - Issue 2182553002: Add other variations (with ids) for NTPSnippets to chrome://flags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/flags_ui/flags_state_unittest.cc

Issue 2182553002: Add other variations (with ids) for NTPSnippets to chrome://flags (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Alexei's comment #5 + fix a bug Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/flags_ui/flags_state_unittest.cc

diff --git a/components/flags_ui/flags_state_unittest.cc b/components/flags_ui/flags_state_unittest.cc

index f8a908fde0a3f0440d67c1d341705372f8aa0963..8a036991d729231b141eb304f7e8c041a5ddb5ac 100644

--- a/components/flags_ui/flags_state_unittest.cc

+++ b/components/flags_ui/flags_state_unittest.cc

@@ -73,7 +73,7 @@ const FeatureEntry::FeatureParam kTestVariationOther[] = {

{kTestParam, kTestParamValue}};

const FeatureEntry::FeatureVariation kTestVariations[] = {

- {"dummy description", kTestVariationOther, 1}};

+ {"dummy description", kTestVariationOther, 1, nullptr}};

// Those have to be valid ids for the translation system but the value are

// never used, so pick one at random from the current component.

« no previous file with comments | « components/flags_ui/flags_state.cc ('k') | components/variations/variations_associated_data.h » ('j') | no next file with comments »