Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Side by Side Diff: components/flags_ui/flags_state.h

Issue 2182553002: Add other variations (with ids) for NTPSnippets to chrome://flags (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove an empty line (added by mistake) Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_FLAGS_UI_FLAGS_STATE_H_ 5 #ifndef COMPONENTS_FLAGS_UI_FLAGS_STATE_H_
6 #define COMPONENTS_FLAGS_UI_FLAGS_STATE_H_ 6 #define COMPONENTS_FLAGS_UI_FLAGS_STATE_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <map> 10 #include <map>
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 const std::string& internal_name, 77 const std::string& internal_name,
78 bool enable); 78 bool enable);
79 void RemoveFlagsSwitches( 79 void RemoveFlagsSwitches(
80 std::map<std::string, base::CommandLine::StringType>* switch_list); 80 std::map<std::string, base::CommandLine::StringType>* switch_list);
81 void ResetAllFlags(FlagsStorage* flags_storage); 81 void ResetAllFlags(FlagsStorage* flags_storage);
82 void Reset(); 82 void Reset();
83 83
84 // Registers variations parameter values selected for features in about:flags. 84 // Registers variations parameter values selected for features in about:flags.
85 // The selected flags are retrieved from |flags_storage|, the registered 85 // The selected flags are retrieved from |flags_storage|, the registered
86 // variation parameters are connected to their corresponding features in 86 // variation parameters are connected to their corresponding features in
87 // |feature_list|. 87 // |feature_list|. Returns the (possibly empty) comma separated list of
88 void RegisterAllFeatureVariationParameters(FlagsStorage* flags_storage, 88 // additional variation ids to register in the MetricsService that come from
89 base::FeatureList* feature_list); 89 // variations selected using chrome://flags.
90 std::string RegisterAllFeatureVariationParameters(
91 FlagsStorage* flags_storage,
92 base::FeatureList* feature_list);
90 93
91 // Gets the list of feature entries. Entries that are available for the 94 // Gets the list of feature entries. Entries that are available for the
92 // current platform are appended to |supported_entries|; all other entries are 95 // current platform are appended to |supported_entries|; all other entries are
93 // appended to |unsupported_entries|. 96 // appended to |unsupported_entries|.
94 void GetFlagFeatureEntries( 97 void GetFlagFeatureEntries(
95 FlagsStorage* flags_storage, 98 FlagsStorage* flags_storage,
96 FlagAccess access, 99 FlagAccess access,
97 base::ListValue* supported_entries, 100 base::ListValue* supported_entries,
98 base::ListValue* unsupported_entries, 101 base::ListValue* unsupported_entries,
99 base::Callback<bool(const FeatureEntry&)> skip_feature_entry); 102 base::Callback<bool(const FeatureEntry&)> skip_feature_entry);
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
176 // Map from switch name to a set of string, that keeps track which strings 179 // Map from switch name to a set of string, that keeps track which strings
177 // were appended to existing (list value) switches. 180 // were appended to existing (list value) switches.
178 std::map<std::string, std::set<std::string>> appended_switches_; 181 std::map<std::string, std::set<std::string>> appended_switches_;
179 182
180 DISALLOW_COPY_AND_ASSIGN(FlagsState); 183 DISALLOW_COPY_AND_ASSIGN(FlagsState);
181 }; 184 };
182 185
183 } // namespace flags_ui 186 } // namespace flags_ui
184 187
185 #endif // COMPONENTS_FLAGS_UI_FLAGS_STATE_H_ 188 #endif // COMPONENTS_FLAGS_UI_FLAGS_STATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698