Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: chrome/browser/about_flags.h

Issue 2182553002: Add other variations (with ids) for NTPSnippets to chrome://flags (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove an empty line (added by mistake) Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/about_flags.cc » ('j') | chrome/browser/about_flags.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ABOUT_FLAGS_H_ 5 #ifndef CHROME_BROWSER_ABOUT_FLAGS_H_
6 #define CHROME_BROWSER_ABOUT_FLAGS_H_ 6 #define CHROME_BROWSER_ABOUT_FLAGS_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 20 matching lines...) Expand all
31 31
32 // Reads the state from |flags_storage| and adds the command line flags 32 // Reads the state from |flags_storage| and adds the command line flags
33 // belonging to the active feature entries to |command_line|. 33 // belonging to the active feature entries to |command_line|.
34 void ConvertFlagsToSwitches(flags_ui::FlagsStorage* flags_storage, 34 void ConvertFlagsToSwitches(flags_ui::FlagsStorage* flags_storage,
35 base::CommandLine* command_line, 35 base::CommandLine* command_line,
36 flags_ui::SentinelsMode sentinels); 36 flags_ui::SentinelsMode sentinels);
37 37
38 // Registers variations parameter values selected for features in about:flags. 38 // Registers variations parameter values selected for features in about:flags.
39 // The selected flags are retrieved from |flags_storage|, the registered 39 // The selected flags are retrieved from |flags_storage|, the registered
40 // variation parameters are connected to their corresponding features in 40 // variation parameters are connected to their corresponding features in
41 // |feature_list|. 41 // |feature_list|. Returns the (possibly empty) comma separated list of
42 void RegisterAllFeatureVariationParameters( 42 // additional variation ids to register in the MetricsService that come from
43 // variations selected using chrome://flags.
44 std::string RegisterAllFeatureVariationParameters(
43 flags_ui::FlagsStorage* flags_storage, 45 flags_ui::FlagsStorage* flags_storage,
44 base::FeatureList* feature_list); 46 base::FeatureList* feature_list);
45 47
46 // Compares a set of switches of the two provided command line objects and 48 // Compares a set of switches of the two provided command line objects and
47 // returns true if they are the same and false otherwise. 49 // returns true if they are the same and false otherwise.
48 // If |out_difference| is not NULL, it's filled with set_symmetric_difference 50 // If |out_difference| is not NULL, it's filled with set_symmetric_difference
49 // between sets. 51 // between sets.
50 bool AreSwitchesIdenticalToCurrentCommandLine( 52 bool AreSwitchesIdenticalToCurrentCommandLine(
51 const base::CommandLine& new_cmdline, 53 const base::CommandLine& new_cmdline,
52 const base::CommandLine& active_cmdline, 54 const base::CommandLine& active_cmdline,
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 100
99 // This value is reported as switch histogram ID if switch name has unknown 101 // This value is reported as switch histogram ID if switch name has unknown
100 // format. 102 // format.
101 extern const base::HistogramBase::Sample kBadSwitchFormatHistogramId; 103 extern const base::HistogramBase::Sample kBadSwitchFormatHistogramId;
102 104
103 } // namespace testing 105 } // namespace testing
104 106
105 } // namespace about_flags 107 } // namespace about_flags
106 108
107 #endif // CHROME_BROWSER_ABOUT_FLAGS_H_ 109 #endif // CHROME_BROWSER_ABOUT_FLAGS_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/about_flags.cc » ('j') | chrome/browser/about_flags.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698