Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: net/cert/ct_log_verifier.cc

Issue 2182533002: Adds a VerifyAuditProof method to CTLogVerifier (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More extensive refactoring Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/ct_log_verifier.h ('k') | net/cert/ct_log_verifier_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/ct_log_verifier.cc
diff --git a/net/cert/ct_log_verifier.cc b/net/cert/ct_log_verifier.cc
index 04eb2f15a1223762735efd915737972b0601f2ae..36d307086897660242bdeb414faab24f275b11e7 100644
--- a/net/cert/ct_log_verifier.cc
+++ b/net/cert/ct_log_verifier.cc
@@ -6,16 +6,19 @@
#include <string.h>
#include <openssl/bytestring.h>
#include <openssl/evp.h>
+#include <vector>
+
#include "base/logging.h"
#include "crypto/openssl_util.h"
#include "crypto/scoped_openssl_types.h"
#include "crypto/sha2.h"
#include "net/cert/ct_log_verifier_util.h"
#include "net/cert/ct_serialization.h"
+#include "net/cert/merkle_audit_proof.h"
#include "net/cert/merkle_consistency_proof.h"
#include "net/cert/signed_tree_head.h"
namespace net {
@@ -241,10 +244,57 @@ bool CTLogVerifier::VerifyConsistencyProof(
// "first_hash" supplied, that the "sr" calculated is equal to the
// "second_hash" supplied and that "sn" is 0.
return fr == old_tree_hash && sr == new_tree_hash && sn == 0;
}
+bool CTLogVerifier::VerifyAuditProof(const ct::MerkleAuditProof& proof,
+ const std::string& root_hash,
+ const std::string& leaf_hash) const {
+ // Implements the algorithm described in
+ // https://tools.ietf.org/html/draft-ietf-trans-rfc6962-bis-17#section-10.4.1
Eran Messeri 2016/10/05 13:17:54 nit: Update the link to point to the latest draft.
Rob Percival 2016/10/05 13:34:50 Done.
+
+ // 1. Compare "leaf_index" against "tree_size". If "leaf_index" is
+ // greater than or equal to "tree_size" fail the proof verification.
+ if (proof.leaf_index >= proof.tree_size)
+ return false;
+
+ // 2. Set "fn" to "leaf_index" and "sn" to "tree_size - 1".
+ uint64_t fn = proof.leaf_index;
+ uint64_t sn = proof.tree_size - 1;
+ // 3. Set "r" to "hash".
+ std::string r = leaf_hash;
+
+ // 4. For each value "p" in the "inclusion_path" array:
+ for (const std::string& p : proof.nodes) {
+ // If "LSB(fn)" is set, or if "fn" is equal to "sn", then:
+ if ((fn & 1) || fn == sn) {
+ // 1. Set "r" to "HASH(0x01 || p || r)"
+ r = ct::internal::HashNodes(p, r);
+
+ // 2. If "LSB(fn)" is not set, then right-shift both "fn" and "sn"
+ // equally until either "LSB(fn)" is set or "fn" is "0".
+ while (!(fn & 1) && fn != 0) {
+ fn >>= 1;
+ sn >>= 1;
+ }
+ } else { // Otherwise:
Eran Messeri 2016/10/05 13:17:54 nit: The comment here does not add much.
Rob Percival 2016/10/05 13:34:50 All of these comments are taken from the RFC. I th
+ // Set "r" to "HASH(0x01 || r || p)"
+ r = ct::internal::HashNodes(r, p);
+ }
+
+ // Finally, right-shift both "fn" and "sn" one time.
+ fn >>= 1;
+ sn >>= 1;
+ }
+
+ // 5. Compare "sn" to 0. Compare "r" against the "root_hash". If "sn"
+ // is equal to 0, and "r" and the "root_hash" are equal, then the
+ // log has proven the inclusion of "hash". Otherwise, fail the
+ // proof verification.
+ return sn == 0 && r == root_hash;
+}
+
CTLogVerifier::~CTLogVerifier() {
crypto::OpenSSLErrStackTracer err_tracer(FROM_HERE);
if (public_key_)
EVP_PKEY_free(public_key_);
« no previous file with comments | « net/cert/ct_log_verifier.h ('k') | net/cert/ct_log_verifier_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698