Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Unified Diff: components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc

Issue 2182493009: Framework for indexing of subresource filtering rules. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Attempt #2 to fix tests on Windows. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc
diff --git a/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc b/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc
index 47c1d1e2450f6c3655bf8381b92ab6ebaae4efd6..2a5cfc0cccbe29b521e766f34381ba0d9d8d6aaf 100644
--- a/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc
+++ b/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc
@@ -7,6 +7,7 @@
#include <memory>
#include <utility>
+#include "base/files/file.h"
#include "base/macros.h"
#include "base/strings/string_piece.h"
#include "base/test/histogram_tester.h"
@@ -80,11 +81,12 @@ class SubresourceFilterAgentTest : public ::testing::Test {
}
void SetTestRulesetToDisallowURLsWithPathSuffix(base::StringPiece suffix) {
- base::File ruleset_file;
+ testing::TestRulesetPair test_ruleset_pair;
ASSERT_NO_FATAL_FAILURE(
- test_ruleset_creator_.CreateRulesetFileToDisallowURLsWithPathSuffix(
- suffix, &ruleset_file));
- ruleset_dealer_.SetRulesetFile(std::move(ruleset_file));
+ test_ruleset_creator_.CreateRulesetToDisallowURLsWithPathSuffix(
+ suffix, &test_ruleset_pair));
+ ruleset_dealer_.SetRulesetFile(
+ testing::TestRuleset::Open(test_ruleset_pair.indexed));
}
void StartLoadWithoutSettingActivationState() {

Powered by Google App Engine
This is Rietveld 408576698