Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1129)

Issue 2182493003: ARM: Implement UnaligedLoad and UnaligedStore turbofan operators. (Closed)

Created:
4 years, 4 months ago by martyn.capewell
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ARM: Implement UnaligedLoad and UnaligedStore turbofan operators. Port 580fdf3c05872b1937a136f2f44b39897ecc0972 This also reverses the MachineType stored for partial unaligned access support such that it records the unsupported types, rather than supported types. BUG= Committed: https://crrev.com/3a6440e48fdc96b00e2eb2faff885115bffa736b Cr-Commit-Position: refs/heads/master@{#38065}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -65 lines) Patch
M src/arm/simulator-arm.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/arm/instruction-codes-arm.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm/instruction-scheduler-arm.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 6 chunks +162 lines, -43 lines 0 comments Download
M src/compiler/machine-operator.h View 3 chunks +17 lines, -17 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
martyn.capewell
4 years, 4 months ago (2016-07-26 12:17:06 UTC) #3
epertoso
lgtm
4 years, 4 months ago (2016-07-26 14:12:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182493003/1
4 years, 4 months ago (2016-07-26 15:33:45 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 15:56:26 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 15:58:29 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a6440e48fdc96b00e2eb2faff885115bffa736b
Cr-Commit-Position: refs/heads/master@{#38065}

Powered by Google App Engine
This is Rietveld 408576698