Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 2182493002: Add per-builder timeouts to catapult waterfall (Closed)

Created:
4 years, 5 months ago by sullivan
Modified:
4 years, 5 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, dtu
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Add per-builder timeouts to catapult waterfall Timeouts are based on looking at current runtimes of the builders: Presubmit takes 15-40 seconds Android takes 10-15 minutes (but is more consistent since there are no browser tests) Linux and max take 8-15 minutes Windows bot takes 20-30 minutes BUG=516784 Committed: https://chromium.googlesource.com/chromium/tools/build/+/0d5107bcbc9dc11dcc105595ed74a6b260cabd94

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M masters/master.tryserver.client.catapult/builders.pyl View 5 chunks +5 lines, -0 lines 0 comments Download
M masters/master.tryserver.client.catapult/master.cfg View 1 chunk +1 line, -1 line 0 comments Download
M masters/master.tryserver.client.catapult/master_site_config.py View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
sullivan
I don't think this CL works correctly. I updated the builders.pyl file instead of the ...
4 years, 5 months ago (2016-07-25 14:19:41 UTC) #2
tandrii(chromium)
your builders.pyl LGTM thanks for such a prompt CL, btw! Responding to your bugs is ...
4 years, 5 months ago (2016-07-25 14:58:54 UTC) #4
sullivan
On 2016/07/25 14:58:54, tandrii(chromium) wrote: > your builders.pyl LGTM > thanks for such a prompt ...
4 years, 5 months ago (2016-07-25 15:04:18 UTC) #5
tandrii(chromium)
On 2016/07/25 15:04:18, sullivan wrote: > On 2016/07/25 14:58:54, tandrii(chromium) wrote: > > your builders.pyl ...
4 years, 5 months ago (2016-07-25 15:13:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182493002/1
4 years, 5 months ago (2016-07-25 15:23:51 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/0d5107bcbc9dc11dcc105595ed74a6b260cabd94
4 years, 5 months ago (2016-07-25 15:27:48 UTC) #10
Dirk Pranke
4 years, 5 months ago (2016-07-25 21:20:34 UTC) #11
Message was sent while issue was closed.
I'm guessing that you re-ran `buildbot-tool gen`? That would cause the copyright
headers to be updated
and the new fields to be added.

However, you only need to re-run that file when you change (some of) the
per-master variables (the
ones that are actually referenced in the templates). The timeout vars are
per-builder and don't (and
shouldn't) show up in the config files, as you see.

I suppose theoretically we could update the generation scripts to be smarter
about leaving the copyrights
alone, but I'm not sure it's worth it.

The CL lgtm though.

Powered by Google App Engine
This is Rietveld 408576698