Add per-builder timeouts to catapult waterfall

Add per-builder timeouts to catapult waterfall

Timeouts are based on looking at current runtimes of the builders:
Presubmit takes 15-40 seconds
Android takes 10-15 minutes (but is more consistent since there are no browser tests)
Linux and max take 8-15 minutes
Windows bot takes 20-30 minutes

BUG=516784
Committed: https://chromium.googlesource.com/chromium/tools/build/+/0d5107bcbc9dc11dcc105595ed74a6b260cabd94

[sullivan, 2016-07-25 14:19:41]

sullivan@chromium.org changed reviewers:
+ dpranke@google.com, iannucci@chromium.org, tandrii@chromium.org

[sullivan, 2016-07-25 14:19:41]

I don't think this CL works correctly. I updated the builders.pyl file instead
of the master.cfg directly as suggested in bug 516784 because it seems like a
bad idea to modify generated files. The builder_timeout_s field is documented
here:
https://cs.chromium.org/chromium/infra/doc/users/services/buildbot/builders.p...

But a couple unexpected things happened:

* There doesn't seem to be any update to the .cfg files about builder timeouts.
* The .cfg files had their copyright updated to 2015. It's my understanding that
copyright dates should not be updated at all, but these files WERE generated in
2015 with a 2014 copyright date so I think that part is correct?
* We got some pubsub updates that aren't expected from our master.cfg files.

For the first problem, tandrii, dpranke, iannucci, do you have any ideas?

For the second two issues, I think these are okay but would like someone on
infra team to verify.

[sullivan, 2016-07-25 14:23:19]

Description was changed from

==========
Add per-builder timeouts to catapult waterfall

BUG=516784
==========

to

==========
Add per-builder timeouts to catapult waterfall

Timeouts are based on looking at current runtimes of the builders:
Presubmit takes 15-40 seconds
Android takes 10-15 minutes (but is more consistent since there are no browser
tests)
Linux and max take 8-15 minutes
Windows bot takes 20-30 minutes

BUG=516784
==========

[tandrii(chromium), 2016-07-25 14:58:54]

your builders.pyl LGTM
thanks for such a prompt CL, btw!
Responding to your bugs is a pleasure.

you didn't have to regenerate anything, so if you are not comfortable with
auto-gen changes, just upload a new patchset with just builders.pyl. That said,
I don't think those are bad changes, nor do *I*[1] care about copyright of
auto-generated files :)

[1] but I'm not a lawyer :)

[sullivan, 2016-07-25 15:04:18]

On 2016/07/25 14:58:54, tandrii(chromium) wrote:
> your builders.pyl LGTM
> thanks for such a prompt CL, btw!
> Responding to your bugs is a pleasure.
> 
> you didn't have to regenerate anything, so if you are not comfortable with
> auto-gen changes, just upload a new patchset with just builders.pyl. That
said,
> I don't think those are bad changes, nor do *I*[1] care about copyright of
> auto-generated files :)
> 
> [1] but I'm not a lawyer :)

Thanks! Just to clarify, the builders.pyl gets used by something directly, so
that is why the generated files do not need to be updated?

[tandrii(chromium), 2016-07-25 15:13:34]

On 2016/07/25 15:04:18, sullivan wrote:
> On 2016/07/25 14:58:54, tandrii(chromium) wrote:
> > your builders.pyl LGTM
> > thanks for such a prompt CL, btw!
> > Responding to your bugs is a pleasure.
> > 
> > you didn't have to regenerate anything, so if you are not comfortable with
> > auto-gen changes, just upload a new patchset with just builders.pyl. That
> said,
> > I don't think those are bad changes, nor do *I*[1] care about copyright of
> > auto-generated files :)
> > 
> > [1] but I'm not a lawyer :)
> 
> Thanks! Just to clarify, the builders.pyl gets used by something directly, so
> that is why the generated files do not need to be updated?

Correct. If you look into master.cfg, it has a line to load "builders.pyl" and
determine config from it.

[sullivan, 2016-07-25 15:23:49]

The CQ bit was checked by sullivan@chromium.org

[commit-bot: I haz the power, 2016-07-25 15:23:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 15:27:47]

Description was changed from

==========
Add per-builder timeouts to catapult waterfall

Timeouts are based on looking at current runtimes of the builders:
Presubmit takes 15-40 seconds
Android takes 10-15 minutes (but is more consistent since there are no browser
tests)
Linux and max take 8-15 minutes
Windows bot takes 20-30 minutes

BUG=516784
==========

to

==========
Add per-builder timeouts to catapult waterfall

Timeouts are based on looking at current runtimes of the builders:
Presubmit takes 15-40 seconds
Android takes 10-15 minutes (but is more consistent since there are no browser
tests)
Linux and max take 8-15 minutes
Windows bot takes 20-30 minutes

BUG=516784

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/0d5107bcbc9dc11dcc10...
==========

[commit-bot: I haz the power, 2016-07-25 15:27:48]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/0d5107bcbc9dc11dcc10...

[Dirk Pranke, 2016-07-25 21:20:34]

I'm guessing that you re-ran `buildbot-tool gen`? That would cause the copyright
headers to be updated
and the new fields to be added.

However, you only need to re-run that file when you change (some of) the
per-master variables (the
ones that are actually referenced in the templates). The timeout vars are
per-builder and don't (and
shouldn't) show up in the config files, as you see.

I suppose theoretically we could update the generation scripts to be smarter
about leaving the copyrights
alone, but I'm not sure it's worth it.

The CL lgtm though.