Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2182443005: Moves TestVolumeControlDelegate to ash/common/test (Closed)

Created:
4 years, 4 months ago by sky
Modified:
4 years, 4 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves TestVolumeControlDelegate to ash/common/test BUG=612331 TEST=none R=msw@chromium.org Committed: https://crrev.com/2bf17c37aec28112cbf60e49c53c33d07497ccfd Cr-Commit-Position: refs/heads/master@{#408228}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -89 lines) Patch
M ash/accelerators/accelerator_controller_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/accelerators/accelerator_interactive_uitest_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/ash.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
A + ash/common/test/test_volume_control_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/test/test_volume_control_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/test/test_volume_control_delegate.h View 1 chunk +0 lines, -46 lines 0 comments Download
D ash/test/test_volume_control_delegate.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_controller_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
sky
4 years, 4 months ago (2016-07-27 20:01:02 UTC) #1
msw
lgtm
4 years, 4 months ago (2016-07-27 20:05:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182443005/1
4 years, 4 months ago (2016-07-27 20:13:06 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 20:39:38 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 20:41:17 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2bf17c37aec28112cbf60e49c53c33d07497ccfd
Cr-Commit-Position: refs/heads/master@{#408228}

Powered by Google App Engine
This is Rietveld 408576698