Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder_unittest_3.cc

Issue 2182443003: WebGL 2: Fix bugs in negativetextureapi.html for Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: small change Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/gles2_cmd_decoder_unittest_3.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_3.cc b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_3.cc
index fc44c8abb0a92e888a49c0b1fdba881923a918cc..65edf3404e8d3eddfe88e0f73175973d840ce328 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_3.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_3.cc
@@ -115,6 +115,17 @@ void GLES2DecoderTestBase::SpecializedSetup<cmds::ValidateProgram, 0>(
.RetiresOnSaturation();
};
+template <>
+void GLES2DecoderTestBase::SpecializedSetup<cmds::CopyTexSubImage3D, 0>(
qiankun 2016/07/27 13:56:26 What's this setup used for?
Zhenyao Mo 2016/07/27 17:38:29 I don't think this is necessary. For the manually
yunchao 2016/07/27 23:46:11 That's true. This code snippet is not necessary.
+ bool valid) {
+ if (valid) {
+ DoBindTexture(GL_TEXTURE_3D, client_texture_id_, kServiceTextureId);
+ DoTexImage3D(
+ GL_TEXTURE_3D, 1, GL_RGBA8, 2, 2, 2, 0, GL_RGBA, GL_UNSIGNED_BYTE,
+ kSharedMemoryId, kSharedMemoryOffset);
+ }
+};
+
TEST_P(GLES2DecoderTest3, TraceBeginCHROMIUM) {
const uint32_t kCategoryBucketId = 123;
const uint32_t kNameBucketId = 234;

Powered by Google App Engine
This is Rietveld 408576698