Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2182443002: [gn] Switch mac to gn (Closed)

Created:
4 years, 5 months ago by Michael Achenbach
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Switch mac to gn BUG=chromium:474921 Committed: https://crrev.com/c2d6d983dee014f3661fd56029669d61cc1443bd Cr-Commit-Position: refs/heads/master@{#38011}

Patch Set 1 #

Patch Set 2 : [gn] Switch mac to gn #

Patch Set 3 : Fixes #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M build_overrides/gtest.gni View 1 2 1 chunk +3 lines, -3 lines 1 comment Download
M infra/mb/mb_config.pyl View 1 6 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
Michael Achenbach
PTAL Comparison links: https://build.chromium.org/p/client.v8/builders/V8%20Mac/builds/9207/steps/compare%20build%20flags%20%28fyi%29/logs/stdio https://build.chromium.org/p/client.v8/builders/V8%20Mac%20-%20debug/builds/8536/steps/compare%20build%20flags%20%28fyi%29/logs/stdio https://build.chromium.org/p/client.v8/builders/V8%20Mac64/builds/10238/steps/compare%20build%20flags%20%28fyi%29/logs/stdio https://build.chromium.org/p/client.v8/builders/V8%20Mac64%20-%20debug/builds/8655/steps/compare%20build%20flags%20%28fyi%29/logs/stdio -fstrict-aliasing has always been off so we don't ...
4 years, 5 months ago (2016-07-25 09:58:04 UTC) #6
Michael Achenbach
And now with reviewers. Please see comment above.
4 years, 5 months ago (2016-07-25 09:58:37 UTC) #8
Michael Achenbach
Hold on for now. Need to resolve a build error on mac.
4 years, 5 months ago (2016-07-25 09:59:17 UTC) #9
Michael Achenbach
PTAL now. https://codereview.chromium.org/2182443002/diff/40001/build_overrides/gtest.gni File build_overrides/gtest.gni (right): https://codereview.chromium.org/2182443002/diff/40001/build_overrides/gtest.gni#newcode9 build_overrides/gtest.gni:9: gtest_include_platform_test = false Use same switches as ...
4 years, 5 months ago (2016-07-25 10:17:15 UTC) #10
vogelheim
lgtm
4 years, 5 months ago (2016-07-25 10:38:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182443002/40001
4 years, 5 months ago (2016-07-25 11:16:29 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-25 11:36:00 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 11:38:16 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c2d6d983dee014f3661fd56029669d61cc1443bd
Cr-Commit-Position: refs/heads/master@{#38011}

Powered by Google App Engine
This is Rietveld 408576698