third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h - Issue 2182423002: [DevTools] Remove V8ContentSearchUtil.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h

Issue 2182423002: [DevTools] Remove V8ContentSearchUtil. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@strings-1

Patch Set: query ensure16bit Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/blink_platform.gypi ('k') | third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h

index cbdab5ef6bbf2eb60f2295228d0684b1cc68f71c..1773fe0f97a83535af8c17ee0a4f91969933d5ff 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h

@@ -64,6 +64,7 @@ public:

void releaseObjectGroup(const String16& objectGroup) override;

v8::Local<v8::Value> findObject(ErrorString*, const String16& objectId, v8::Local<v8::Context>* = nullptr, String16* groupName = nullptr) override;

std::unique_ptr<protocol::Runtime::API::RemoteObject> wrapObject(v8::Local<v8::Context>, v8::Local<v8::Value>, const String16& groupName) override;

+ std::unique_ptr<protocol::Array<protocol::Debugger::API::SearchMatch>> searchInTextByLines(const uint16_t* text, size_t textLength, const uint16_t* query, size_t queryLength, const bool caseSensitive, const bool isRegex) override;

kozy 2016/07/27 01:17:05 "const bool" -> "bool"

dgozman 2016/07/27 01:19:12 Done.

V8InspectorSession::Inspectable* inspectedObject(unsigned num);

static const unsigned kInspectedObjectBufferSize = 5;