third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp - Issue 2182423002: [DevTools] Remove V8ContentSearchUtil.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp

Issue 2182423002: [DevTools] Remove V8ContentSearchUtil. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@strings-1

Patch Set: query ensure16bit Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/blink_platform.gypi » ('j') | third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp

index d11f14f57847e05c7cf959eb15a61e7784afbc5b..1ce19cb0166fb162e8918e72a9856a422578ece5 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp

@@ -63,7 +63,6 @@

#include "platform/PlatformResourceLoader.h"

#include "platform/UserGestureIndicator.h"

#include "platform/inspector_protocol/Values.h"

-#include "platform/v8_inspector/public/V8ContentSearchUtil.h"

#include "platform/v8_inspector/public/V8InspectorSession.h"

#include "platform/weborigin/SecurityOrigin.h"

#include "wtf/CurrentTime.h"

@@ -516,7 +515,10 @@ void InspectorPageAgent::searchContentAfterResourcesContentLoaded(const String&

return;

}

- callback->sendSuccess(V8ContentSearchUtil::searchInTextByLines(m_v8Session, content, query, caseSensitive, isRegex));

+ content.ensure16Bit();

+ String query16 = query;

+ query16.ensure16Bit();

+ callback->sendSuccess(m_v8Session->searchInTextByLines(content.characters16(), content.length(), query16.characters16(), query16.length(), caseSensitive, isRegex));

}

void InspectorPageAgent::searchInResource(ErrorString*, const String& frameId, const String& url, const String& query, const Maybe<bool>& optionalCaseSensitive, const Maybe<bool>& optionalIsRegex, std::unique_ptr<SearchInResourceCallback> callback)